-
Notifications
You must be signed in to change notification settings - Fork 48
chore: rename repo to comply with logos #2757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - uses: actions/checkout@v3 | ||
| with: | ||
| repository: waku-org/js-waku | ||
| repository: logos-messaging/logos-messaging-js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI workflows clone the wrong repository
The CI jobs now override actions/checkout to pull logos-messaging/logos-messaging-js, even though this repository (and the issue URL in the commit description) is logos-messaging/js-waku. When the workflow runs it will clone that other/nonexistent repo instead of the PR’s code, so subsequent build, test, and release steps won’t exercise the changes here and may fail outright if that repo is missing.
Useful? React with 👍 / 👎.
| const branch = "gh-pages"; | ||
| const org = "waku-org"; | ||
| const repo = "js-waku"; | ||
| const org = "logos-messaging"; | ||
| const repo = "logos-messaging-js"; | ||
| /* use SSH auth by default */ | ||
| let repoUrl = USE_HTTPS | ||
| ? `https://github.com/${org}/${repo}.git` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs deployment targets the wrong GitHub Pages repo
The deploy script now pushes the generated docs to logos-messaging/logos-messaging-js’s gh-pages branch instead of this project (logos-messaging/js-waku, as referenced elsewhere in the repo and the commit message). Running npm run deploy will therefore publish to the wrong repository or fail if that repo isn’t configured, leaving the documentation for this project unchanged.
Useful? React with 👍 / 👎.
size-limit report 📦
|
|
CI breaks expectedly, after review I will rename the repo before merging. |
Problem / Description
We are unifying under Logos.
Solution
Rename repo to comply.
This PR renames only repo and public facing exports.
We will continue releasing under @waku namespace for now.
Notes