Skip to content

Conversation

@weboko
Copy link
Collaborator

@weboko weboko commented May 31, 2025

pretty much what is in the title

image

@weboko weboko requested a review from Copilot May 31, 2025 16:02
@weboko weboko force-pushed the weboko/up-dogfooding-app-1 branch from 480c6c3 to 4256472 Compare May 31, 2025 16:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the dogfooding example by rebuilding the UI, modularizing Waku-related logic into services, and updating the asset pipeline.

  • Overhauled webpack config to use explicit copy patterns and removed the DefinePlugin.
  • Split Waku setup, message encoding/decoding, and UI rendering into separate modules.
  • Rebuilt HTML/CSS to a modern, responsive layout with live filtering of messages.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
examples/dogfooding/webpack.config.js Updated CopyWebpackPlugin patterns; removed DefinePlugin usage.
examples/dogfooding/src/waku-service.ts Encapsulated LightNode creation and bootstrap logic.
examples/dogfooding/src/utils.ts Added SHA-256 and random number helpers.
examples/dogfooding/src/util.ts Removed legacy telemetry helper functions.
examples/dogfooding/src/ui-manager.ts Centralized DOM updates and message rendering logic.
examples/dogfooding/src/telemetry_client.ts Removed unused telemetry client.
examples/dogfooding/src/message-service.ts Defined protobuf model and encode/decode helpers.
examples/dogfooding/src/index.ts Refactored app init to use new services; wired UI event handlers.
examples/dogfooding/public/style.css New responsive styles for the app container and message list.
examples/dogfooding/package.json Bumped @waku/sdk to 0.0.32-16328a3.0.
examples/dogfooding/index.html Updated markup for new UI sections and asset links.
Files not reviewed (1)
  • examples/dogfooding/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

examples/dogfooding/src/ui-manager.ts:11

  • [nitpick] The variable receivedMine is ambiguous; consider renaming to receivedByMe or receivedSelf for clarity.
let receivedMine = 0;

@weboko weboko force-pushed the weboko/up-dogfooding-app-1 branch from 78bc160 to 4256472 Compare May 31, 2025 16:07
@weboko weboko force-pushed the weboko/up-dogfooding-app-1 branch from 54e591b to ed223d3 Compare June 2, 2025 16:38
@weboko weboko merged commit dc935bc into master Jun 2, 2025
11 checks passed
@weboko weboko deleted the weboko/up-dogfooding-app-1 branch June 2, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants