chore: update waku deps, add notes example, move other examples to experimental #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
chore/update-waku-deps
branch
7 times, most recently
from
7a3da3b to
040d381
Compare
danisharora099
approved these changes
Apr 18, 2024
Contributor
danisharora099
left a comment
danisharora099
left a comment
There was a problem hiding this comment.
@adklempner approving since work has been done here but I'd propose to remove the examples we don't require to maintain cc @weboko
also some CIs fail
adklempner
force-pushed
the
chore/update-waku-deps
branch
2 times, most recently
from
67da25d to
ceb40bb
Compare
weboko
reviewed
Apr 23, 2024
| import { | ||
| enrTree, | ||
| DnsNodeDiscovery, | ||
| } from "https://unpkg.com/@waku/[email protected]/bundle/index.js"; |
Collaborator
There was a problem hiding this comment.
is it intentional? I think latest is better to be used
Member
Author
There was a problem hiding this comment.
updated to use current next tag
weboko
reviewed
Apr 23, 2024
| @@ -9,9 +9,9 @@ | |||
| "start": "webpack-dev-server" | |||
| }, | |||
| "dependencies": { | |||
| "@waku/sdk": "0.0.18", | |||
| "@waku/noise": "0.0.3-31510da", | |||
Collaborator
There was a problem hiding this comment.
please, check which one is latest version of noise
Member
Author
There was a problem hiding this comment.
updated to use current next tag
adklempner
force-pushed
the
chore/update-waku-deps
branch
5 times, most recently
from
3525ae8 to
ab8c5fb
Compare
adklempner
changed the title
chore: update waku deps to latest chore: remove relay chats, move all examples to experimental, add notes example fix: notes example: use nightly waku deps and set pubsub topic in node/enc/dec
adklempner
force-pushed
the
chore/update-waku-deps
branch
from
ab8c5fb to
172d2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimentalResolves #59