Skip to content

feat: add light push v3 protocol detection and handling#2483

Closed
adklempner wants to merge 3 commits into
masterfrom
feat/lp-v3-detection
Closed

feat: add light push v3 protocol detection and handling#2483
adklempner wants to merge 3 commits into
masterfrom
feat/lp-v3-detection

Conversation

@adklempner

@adklempner adklempner commented Jul 14, 2025

Copy link
Copy Markdown
Member

Problem / Description

Solution

Notes


Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@github-actions

github-actions Bot commented Jul 14, 2025

Copy link
Copy Markdown

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 71.1 KB (+1.28% 🔺) 1.5 s (+1.28% 🔺) 2.2 s (+34.35% 🔺) 3.6 s
Waku Simple Light Node 123.16 KB (+0.74% 🔺) 2.5 s (+0.74% 🔺) 3 s (+3.91% 🔺) 5.4 s
ECIES encryption 23.44 KB (+1.68% 🔺) 469 ms (+1.68% 🔺) 979 ms (+1.32% 🔺) 1.5 s
Symmetric encryption 22.96 KB (+2.27% 🔺) 460 ms (+2.27% 🔺) 775 ms (-11.6% 🔽) 1.3 s
DNS discovery 52.37 KB (+0.81% 🔺) 1.1 s (+0.81% 🔺) 1.9 s (+14.52% 🔺) 3 s
Peer Exchange discovery 52.84 KB (+0.84% 🔺) 1.1 s (+0.84% 🔺) 2.2 s (+61.38% 🔺) 3.2 s
Local Peer Cache Discovery 46.48 KB (+0.84% 🔺) 930 ms (+0.84% 🔺) 1.3 s (-12.9% 🔽) 2.3 s
Privacy preserving protocols 53.9 KB (+0.79% 🔺) 1.1 s (+0.79% 🔺) 2 s (-4.83% 🔽) 3.1 s
Waku Filter 55.74 KB (+0.68% 🔺) 1.2 s (+0.68% 🔺) 1.9 s (+49.69% 🔺) 3.1 s
Waku LightPush 53.88 KB (+1.89% 🔺) 1.1 s (+1.89% 🔺) 2.5 s (+72.1% 🔺) 3.6 s
History retrieval protocols 59.48 KB (+0.61% 🔺) 1.2 s (+0.61% 🔺) 2.6 s (+50.46% 🔺) 3.7 s
Deterministic Message Hashing 28.85 KB (+1.63% 🔺) 578 ms (+1.63% 🔺) 1.4 s (+38.39% 🔺) 2 s

@adklempner
adklempner force-pushed the feat/lp-v3-detection branch 2 times, most recently from 4b9ed45 to 3384701 Compare July 16, 2025 23:40
- Export LightPushCodecV3 and LightPushCodecs from core package
- Add v3 protocol support tests with status code validation
- Add mock functions for v3 responses and RLN errors
- Test mixed v2/v3 peer scenarios
- Validate protocol error mapping and status code handling
- Fix linting errors by adding explicit return types
@adklempner
adklempner force-pushed the feat/lp-v3-detection branch from 3384701 to 41301ea Compare July 16, 2025 23:41
@weboko

weboko commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

closing in favor of #2501

@weboko weboko closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lp-v3: determine if light push peer supports v3

2 participants