fix: make health events emission consistent#2570
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the HealthIndicator to make health state re-calculation more consistent and comprehensible by extracting the health assessment logic into a single method that is called on every relevant event.
- Extracts health assessment logic into a centralized
assessHealth()method - Adds initial health assessment when the indicator starts
- Simplifies event handlers to consistently call the assessment method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/sdk/src/health_indicator/health_indicator.ts | Refactors health logic into assessHealth() method and adds initial assessment on start |
| packages/sdk/src/health_indicator/health_indicator.spec.ts | Updates tests to handle new behavior and adds comprehensive test coverage for edge cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adklempner
approved these changes
Aug 19, 2025
weboko
force-pushed
the
weboko/health-events
branch
from
August 20, 2025 10:09
2744660 to
8c865b3
Compare
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Description
Health indicator has difficult logic to comprehend leading to bugs being easily introduced.
Solution
Make clear re-calculation of health state on every event.
Notes