chore: rename repo to comply with logos#2757
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - uses: actions/checkout@v3 | ||
| with: | ||
| repository: waku-org/js-waku | ||
| repository: logos-messaging/logos-messaging-js |
There was a problem hiding this comment.
The CI jobs now override actions/checkout to pull logos-messaging/logos-messaging-js, even though this repository (and the issue URL in the commit description) is logos-messaging/js-waku. When the workflow runs it will clone that other/nonexistent repo instead of the PR’s code, so subsequent build, test, and release steps won’t exercise the changes here and may fail outright if that repo is missing.
Useful? React with 👍 / 👎.
| const branch = "gh-pages"; | ||
| const org = "waku-org"; | ||
| const repo = "js-waku"; | ||
| const org = "logos-messaging"; | ||
| const repo = "logos-messaging-js"; | ||
| /* use SSH auth by default */ | ||
| let repoUrl = USE_HTTPS | ||
| ? `https://github.com/${org}/${repo}.git` |
There was a problem hiding this comment.
The deploy script now pushes the generated docs to logos-messaging/logos-messaging-js’s gh-pages branch instead of this project (logos-messaging/js-waku, as referenced elsewhere in the repo and the commit message). Running npm run deploy will therefore publish to the wrong repository or fail if that repo isn’t configured, leaving the documentation for this project unchanged.
Useful? React with 👍 / 👎.
size-limit report 📦
|
|
CI breaks expectedly, after review I will rename the repo before merging. |
2 participants
Problem / Description
We are unifying under Logos.
Solution
Rename repo to comply.
This PR renames only repo and public facing exports.
We will continue releasing under @waku namespace for now.
Notes