Add minimum mint value to use mintWithEth function#44
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a minimum mint value requirement to the TestStableToken's mintWithEth function to prevent potential spam attacks. Previously, any amount of ETH could be used to mint tokens, creating a risk for micro-transactions that could spam the network.
- Added 1 ETH minimum requirement for the mintWithEth function
- Updated all existing tests to use compliant amounts (≥1 ETH)
- Added comprehensive test coverage for the new minimum requirement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/TestStableToken.sol | Introduces MIN_MINT_WEI constant and updates mintWithETH validation logic |
| test/TestStableToken.t.sol | Adds new tests for minimum requirement and updates existing tests to use compliant amounts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
0x-r4bbit
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TestStableToken previously had no lower limit to mint tokens. There is a possible risk for spamming because of this.
A minimum of 1 ETH has been added to the mintWithEth function, but there is no lower limit to mint if you are an approved minter.
Checklist
Ensure you completed all of the steps below before submitting your pull request: