Skip to content

Comments

chore: mix updates#3570

Merged
chaitanyaprem merged 3 commits intomasterfrom
chore/mix-updates
Sep 22, 2025
Merged

chore: mix updates#3570
chaitanyaprem merged 3 commits intomasterfrom
chore/mix-updates

Conversation

@chaitanyaprem
Copy link
Contributor

@chaitanyaprem chaitanyaprem commented Sep 15, 2025 •
edited
Loading

Description

Some minor updates

Changes

  • Update mix to include fix for destination being included in mix pool
  • update wakucanary to test using mix
  • fix liteprotocoltester

Reference issue #3280

@github-actions
Copy link

github-actions bot commented Sep 15, 2025 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3570

Built from 364c671

fryorcraken
fryorcraken reviewed Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@fryorcraken fryorcraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to fix the liteprotocoltester while you're here :)

fryorcraken
fryorcraken approved these changes Sep 16, 2025
View reviewed changes
NagyZoltanPeter
NagyZoltanPeter approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all great, thank you!

@chaitanyaprem
Copy link
Contributor Author

chaitanyaprem commented Sep 16, 2025 •
edited
Loading

One of the tests for peerManager is failing which i think is because the latest master has a fix for connection being marked as closed. Since we reverted back to 1.12.0 eventhough the test functionally is correct (i.e metadata disconnects on different clusterIDs), it still fails as check for connection closed is failing.

@waku-org/nwaku was this test failing before this update? If not, any change to be done to make it pass.

@NagyZoltanPeter
Copy link
Contributor

NagyZoltanPeter commented Sep 16, 2025

@chaitanyaprem Is this PR connected to issue #3280?

@chaitanyaprem
Copy link
Contributor Author

chaitanyaprem commented Sep 16, 2025

@chaitanyaprem Is this PR connected to issue #3280?

Yes and some issues @fryorcraken has noticed.

fryorcraken
fryorcraken reviewed Sep 17, 2025
View reviewed changes
Ivansete-status
Ivansete-status approved these changes Sep 21, 2025
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for it! 💯
I think just undo the nim-libp2p bump, as it was done in master already, and adding tiny nitpick comment.
Cheers

@chaitanyaprem chaitanyaprem merged commit 041615b into master Sep 22, 2025
10 of 12 checks passed
@chaitanyaprem chaitanyaprem deleted the chore/mix-updates branch September 22, 2025 12:19
Ivansete-status pushed a commit that referenced this pull request Jan 28, 2026
@chaitanyaprem
chore: mix updates (#3570)
2691dcb 
* mix updates and fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fryorcraken fryorcraken fryorcraken approved these changes

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

Assignees

@chaitanyaprem chaitanyaprem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chaitanyaprem @NagyZoltanPeter @fryorcraken @Ivansete-status