Skip to content

Comments

Fix protocol connection close#3588

Merged
Ivansete-status merged 2 commits intomasterfrom
fix-protocol-connection-close
Oct 3, 2025
Merged

Fix protocol connection close#3588
Ivansete-status merged 2 commits intomasterfrom
fix-protocol-connection-close

Conversation

@Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Sep 30, 2025 •
edited
Loading

Original PR: #3583
Original author: @NagyZoltanPeter

The original PR got abruptly closed after a deep cleanup and refactor applied by this on 2025-09-30

Description

Changes

  • closeWithEof for protocol handler and client requests sides:
  • lightpush
  • legacy lightpush
  • filter

Exception

  • filter push - needs review of reusing streams.

Issue

closes #3582

@Ivansete-status Ivansete-status marked this pull request as ready for review September 30, 2025 19:18
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3588

Built from ef887b3

@NagyZoltanPeter
Copy link
Contributor

NagyZoltanPeter commented Oct 3, 2025

MacOs-13 failing with this:

./build/tests/waku_store_sync/test_protocol.nim.bin "Waku Sync: reconciliation::sync 2 nodes, 40 msgs: 18 in-window diff, 20 out-window ignored"
Waku Sync: reconciliation DBG 2025-10-01 18:35:16.418+02:00 starting switch for peer                   topics="libp2p switch" tid=15586483 file=switch.nim:350 peerInfo="(peerId: 16Uiu2HAmUrMbs77U7tkng4ApgMDwjdqZq1b3Bsa6Wet27Z7q528v, listenAddrs: [/ip4/127.0.0.1/tcp/0], addrs: [], protocols: [/ipfs/id/1.0.0], protoVersion: ipfs/0.1.0, agentVersion: nim-libp2p/0.0.1)"
DBG 2025-10-01 18:35:16.419+02:00 About to accept incoming connection        topics="libp2p switch" tid=15586483 file=switch.nim:268
DBG 2025-10-01 18:35:16.419+02:00 Setting up WildcardAddressResolverService  topics="libp2p wildcardresolverservice" tid=15586483 file=wildcardresolverservice.nim:166
DBG 2025-10-01 18:35:16.420+02:00 Started libp2p node                        topics="libp2p switch" tid=15586483 file=switch.nim:390 peer="(peerId: 16Uiu2HAmUrMbs77U7tkng4ApgMDwjdqZq1b3Bsa6Wet27Z7q528v, listenAddrs: [/ip4/127.0.0.1/tcp/50264], addrs: [/ip4/127.0.0.1/tcp/50264], protocols: [/ipfs/id/1.0.0], protoVersion: ipfs/0.1.0, agentVersion: nim-libp2p/0.0.1)"
DBG 2025-10-01 18:35:16.420+02:00 starting switch for peer                   topics="libp2p switch" tid=15586483 file=switch.nim:350 peerInfo="(peerId: 16Uiu2HAkvzYky86N2NQ1qadbPXNoD73CjhrKyeFrrwxZzauxZFoX, listenAddrs: [/ip4/127.0.0.1/tcp/0], addrs: [], protocols: [/ipfs/id/1.0.0], protoVersion: ipfs/0.1.0, agentVersion: nim-libp2p/0.0.1)"
DBG 2025-10-01 18:35:16.420+02:00 About to accept incoming connection        topics="libp2p switch" tid=15586483 file=switch.nim:268
DBG 2025-10-01 18:35:16.420+02:00 Setting up WildcardAddressResolverService  topics="libp2p wildcardresolverservice" tid=15586483 file=wildcardresolverservice.nim:166
DBG 2025-10-01 18:35:16.420+02:00 Started libp2p node                        topics="libp2p switch" tid=15586483 file=switch.nim:390 peer="(peerId: 16Uiu2HAkvzYky86N2NQ1qadbPXNoD73CjhrKyeFrrwxZzauxZFoX, listenAddrs: [/ip4/127.0.0.1/tcp/50265], addrs: [/ip4/127.0.0.1/tcp/50265], protocols: [/ipfs/id/1.0.0], protoVersion: ipfs/0.1.0, agentVersion: nim-libp2p/0.0.1)"
WRN 2025-10-01 18:35:16.420+02:00 will not sync messages before this point in time tid=15586483 file=reconciliation.nim:399 error="waku archive unavailable"
INF 2025-10-01 18:35:16.420+02:00 Store Reconciliation protocol initialized  tid=15586483 file=reconciliation.nim:427 sync_range=1h sync_interval=5m relay_jitter=
DBG 2025-10-01 18:35:16.421+02:00 periodic sync initialized                  topics="waku reconciliation" tid=15586483 file=reconciliation.nim:433 interval=5m
DBG 2025-10-01 18:35:16.421+02:00 periodic prune initialized                 topics="waku reconciliation" tid=15586483 file=reconciliation.nim:447 interval=5m
INF 2025-10-01 18:35:16.421+02:00 Store Sync Reconciliation protocol started topics="waku reconciliation" tid=15586483 file=reconciliation.nim:485
WRN 2025-10-01 18:35:16.421+02:00 will not sync messages before this point in time tid=15586483 file=reconciliation.nim:399 error="waku archive unavailable"
INF 2025-10-01 18:35:16.421+02:00 Store Reconciliation protocol initialized  tid=15586483 file=reconciliation.nim:427 sync_range=1h sync_interval=5m relay_jitter=
DBG 2025-10-01 18:35:16.421+02:00 periodic sync initialized                  topics="waku reconciliation" tid=15586483 file=reconciliation.nim:433 interval=5m
DBG 2025-10-01 18:35:16.421+02:00 periodic prune initialized                 topics="waku reconciliation" tid=15586483 file=reconciliation.nim:447 interval=5m
INF 2025-10-01 18:35:16.421+02:00 Store Sync Reconciliation protocol started topics="waku reconciliation" tid=15586483 file=reconciliation.nim:485
WRN 2025-10-01 18:35:16.421+02:00 will not sync messages before this point in time tid=15586483 file=reconciliation.nim:399 error="waku archive unavailable"
INF 2025-10-01 18:35:16.421+02:00 Store Reconciliation protocol initialized  tid=15586483 file=reconciliation.nim:427 sync_range=1s sync_interval=5m relay_jitter=
DBG 2025-10-01 18:35:16.421+02:00 periodic sync initialized                  topics="waku reconciliation" tid=15586483 file=reconciliation.nim:433 interval=5m
DBG 2025-10-01 18:35:16.421+02:00 periodic prune initialized                 topics="waku reconciliation" tid=15586483 file=reconciliation.nim:447 interval=5m
INF 2025-10-01 18:35:16.421+02:00 Store Sync Reconciliation protocol started topics="waku reconciliation" tid=15586483 file=reconciliation.nim:485
WRN 2025-10-01 18:35:16.421+02:00 will not sync messages before this point in time tid=15586483 file=reconciliation.nim:399 error="waku archive unavailable"
INF 2025-10-01 18:35:16.421+02:00 Store Reconciliation protocol initialized  tid=15586483 file=reconciliation.nim:427 sync_range=1s sync_interval=5m relay_jitter=
DBG 2025-10-01 18:35:16.421+02:00 periodic sync initialized                  topics="waku reconciliation" tid=15586483 file=reconciliation.nim:433 interval=5m
DBG 2025-10-01 18:35:16.421+02:00 periodic prune initialized                 topics="waku reconciliation" tid=15586483 file=reconciliation.nim:447 interval=5m
INF 2025-10-01 18:35:16.421+02:00 Store Sync Reconciliation protocol started topics="waku reconciliation" tid=15586483 file=reconciliation.nim:485
DBG 2025-10-01 18:35:16.421+02:00 Dialing peer                               topics="libp2p dialer" tid=15586483 file=dialer.nim:147 peerId=16U*7q528v addrs="[/ip4/127.0.0.1/tcp/50264]"
DBG 2025-10-01 18:35:16.421+02:00 Expanded address and hostname              topics="libp2p dialer" tid=15586483 file=dialer.nim:162 expandedAddress=/ip4/127.0.0.1/tcp/50264 hostname=127.0.0.1 resolvedAddresses="[/ip4/127.0.0.1/tcp/50264]"
DBG 2025-10-01 18:35:16.422+02:00 Accepted an incoming connection            topics="libp2p switch" tid=15586483 file=switch.nim:298 conn=:68dd5844139d50da2ff527cf
DBG 2025-10-01 18:35:16.422+02:00 About to accept incoming connection        topics="libp2p switch" tid=15586483 file=switch.nim:268
DBG 2025-10-01 18:35:16.425+02:00 Dial successful                            topics="libp2p dialer" tid=15586483 file=dialer.nim:98 peerId=16U*7q528v
DBG 2025-10-01 18:35:16.426+02:00 identify: decoded message                  topics="libp2p identify" tid=15586483 file=identify.nim:183 conn=16U*uxZFoX:68dd5844139d50da2ff527d3 pubkey=some(s...380a)) addresses=/ip4/127.0.0.1/tcp/50265 protocols=/ipfs/id/1.0.0,/vac/waku/reconciliation/1.0.0,/vac/waku/reconciliation/1.0.0 observable_address=some(/ip4/127.0.0.1/tcp/50264) proto_version=ipfs/0.1.0 agent_version=nim-libp2p/0.0.1 signedPeerRecord=None
DBG 2025-10-01 18:35:16.426+02:00 identify: decoded message                  topics="libp2p identify" tid=15586483 file=identify.nim:183 conn=16U*7q528v:68dd5844139d50da2ff527d6 pubkey=some(s...dbb5)) addresses=/ip4/127.0.0.1/tcp/50264 protocols=/ipfs/id/1.0.0,/vac/waku/reconciliation/1.0.0,/vac/waku/reconciliation/1.0.0 observable_address=some(/ip4/127.0.0.1/tcp/50266) proto_version=ipfs/0.1.0 agent_version=nim-libp2p/0.0.1 signedPeerRecord=None
DBG 2025-10-01 18:35:16.427+02:00 sync session initialized                   topics="waku reconciliation" tid=15586483 file=reconciliation.nim:321 local=16U*uxZFoX remote=16U*7q528v
DBG 2025-10-01 18:35:16.428+02:00 sync session ended gracefully              topics="waku reconciliation" tid=15586483 file=reconciliation.nim:334 local=16U*uxZFoX remote=16U*7q528v
DBG 2025-10-01 18:40:16.426+02:00 periodic sync started                      topics="waku reconciliation" tid=15586483 file=reconciliation.nim:438
DBG 2025-10-01 18:40:16.429+02:00 periodic sync started                      topics="waku reconciliation" tid=15586483 file=reconciliation.nim:438
DBG 2025-10-01 18:40:16.429+02:00 periodic sync started                      topics="waku reconciliation" tid=15586483 file=reconciliation.nim:438
DBG 2025-10-01 18:40:16.429+02:00 periodic sync started                      topics="waku reconciliation" tid=15586483 file=reconciliation.nim:438
DBG 2025-10-01 18:40:16.433+02:00 sync session initialized                   topics="waku reconciliation" tid=15586483 file=reconciliation.nim:321 local=16U*7q528v remote=16U*uxZFoX
DBG 2025-10-01 18:40:16.433+02:00 sync session initialized                   topics="waku reconciliation" tid=15586483 file=reconciliation.nim:321 local=16U*uxZFoX remote=16U*7q528v
DBG 2025-10-01 18:40:16.434+02:00 sync session initialized                   topics="waku reconciliation" tid=15586483 file=reconciliation.nim:321 local=16U*7q528v remote=16U*uxZFoX
DBG 2025-10-01 18:40:16.434+02:00 sync session initialized                   topics="waku reconciliation" tid=15586483 file=reconciliation.nim:321 local=16U*uxZFoX remote=16U*7q528v
INF 2025-10-01 18:40:16.436+02:00 Store Sync Reconciliation protocol stopped topics="waku reconciliation" tid=15586483 file=reconciliation.nim:496
INF 2025-10-01 18:40:16.436+02:00 Store Sync Reconciliation protocol stopped topics="waku reconciliation" tid=15586483 file=reconciliation.nim:496
DBG 2025-10-01 18:40:16.436+02:00 sync session ended gracefully              topics="waku reconciliation" tid=15586483 file=reconciliation.nim:334 local=16U*7q528v remote=16U*uxZFoX
DBG 2025-10-01 18:40:16.436+02:00 sync session ended gracefully              topics="waku reconciliation" tid=15586483 file=reconciliation.nim:334 local=16U*7q528v remote=16U*uxZFoX
DBG 2025-10-01 18:40:16.436+02:00 periodic sync done                         topics="waku reconciliation" tid=15586483 file=reconciliation.nim:444
DBG 2025-10-01 18:40:16.436+02:00 periodic sync done                         topics="waku reconciliation" tid=15586483 file=reconciliation.nim:444
DBG 2025-10-01 18:40:16.436+02:00 sync session ended gracefully              topics="waku reconciliation" tid=15586483 file=reconciliation.nim:334 local=16U*uxZFoX remote=16U*7q528v
INF 2025-10-01 18:40:16.436+02:00 Store Sync Reconciliation protocol stopped topics="waku reconciliation" tid=15586483 file=reconciliation.nim:496
INF 2025-10-01 18:40:16.436+02:00 Store Sync Reconciliation protocol stopped topics="waku reconciliation" tid=15586483 file=reconciliation.nim:496
DBG 2025-10-01 18:40:16.437+02:00 periodic sync done                         topics="waku reconciliation" tid=15586483 file=reconciliation.nim:444
DBG 2025-10-01 18:40:16.437+02:00 Stopping WildcardAddressResolverService    topics="libp2p wildcardresolverservice" tid=15586483 file=wildcardresolverservice.nim:198
DBG 2025-10-01 18:40:16.438+02:00 Stopping WildcardAddressResolverService    topics="libp2p wildcardresolverservice" tid=15586483 file=wildcardresolverservice.nim:198
ERR 2025-10-01 18:40:16.439+02:00 request processing error                   tid=15586483 file=reconciliation.nim:420 error="remote 16Uiu2HAmUrMbs77U7tkng4ApgMDwjdqZq1b3Bsa6Wet27Z7q528v connection read error: Stream Underlying Connection Closed!"
ERR 2025-10-01 18:40:16.439+02:00 request processing error                   tid=15586483 file=reconciliation.nim:420 error="remote 16Uiu2HAkvzYky86N2NQ1qadbPXNoD73CjhrKyeFrrwxZzauxZFoX connection read error: Stream Closed!"
ERR 2025-10-01 18:40:16.440+02:00 sync session failed                        topics="waku reconciliation" tid=15586483 file=reconciliation.nim:329 local=16U*uxZFoX remote=16U*7q528v err="remote 16Uiu2HAmUrMbs77U7tkng4ApgMDwjdqZq1b3Bsa6Wet27Z7q528v connection read error: Stream Closed!"
ERR 2025-10-01 18:40:16.440+02:00 periodic sync failed                       topics="waku reconciliation" tid=15586483 file=reconciliation.nim:441 err="sync request error: remote 16Uiu2HAmUrMbs77U7tkng4ApgMDwjdqZq1b3Bsa6Wet27Z7q528v connection read error: Stream Closed!"
F (300.0s)
===============================================================
  /Users/schwarzy/dev/status/nwakuslim/build/tests/waku_store_sync/test_protocol.nim.bin 'Waku Sync: reconciliation::sync 2 nodes, 40 msgs: 18 in-window diff, 20 out-window ignored'
---------------------------------------------------------------
    /Users/schwarzy/dev/status/nwakuslim/tests/waku_store_sync/test_protocol.nim(570, 26): Check failed: remoteNeeds.len == diffInWin
    remoteNeeds.len was 17
    diffInWin was 18
    /Users/schwarzy/dev/status/nwakuslim/tests/waku_store_sync/test_protocol.nim(574, 28): Check failed: deliveredHashes in inWinHashes
    deliveredHashes was 0xdd59...fb1d
    inWinHashes was {[80, 245, 188, 234, 116, 201, 40, 250, 140, 103, 77, 157, 117, 97, 254, 89, 205, 89, 176, 56, 40, 9, 72, 232, 165, 116, 233, 75, 43, 143, 178, 217], [139, 39, 77, 151, 32, 104, 239, 0, 64, 110, 164, 54, 41, 19, 154, 82, 207, 209, 95, 245, 161, 24, 251, 87, 141, 22, 222, 94, 30, 163, 210, 65], [63, 99, 51, 245, 121, 31, 79, 228, 16, 116, 194, 210, 222, 231, 217, 32, 222, 191, 147, 114, 126, 109, 219, 115, 61, 195, 69, 220, 20, 29, 242, 0], [227, 192, 164, 178, 16, 217, 21, 162, 144, 250, 36, 184, 120, 91, 108, 204, 75, 105, 30, 127, 134, 199, 52, 71, 7, 249, 138, 238, 85, 95, 105, 168], [148, 251, 125, 220, 186, 37, 170, 49, 19, 34, 36, 234, 149, 103, 229, 60, 174, 135, 200, 92, 131, 201, 47, 210, 102, 184, 230, 220, 153, 208, 90, 151], [63, 25, 81, 5, 167, 232, 146, 173, 195, 27, 221, 67, 110, 171, 161, 100, 68, 62, 204, 226, 109, 5, 39, 106, 41, 44, 175, 145, 193, 185, 75, 169], [137, 221, 113, 146, 32, 154, 203, 18, 78, 214, 85, 47, 84, 70, 27, 40, 21, 217, 103, 61, 74, 166, 160, 197, 127, 126, 19, 105, 195, 40, 121, 69], [193, 172, 183, 17, 248, 35, 141, 2, 140, 197, 136, 186, 59, 233, 38, 171, 154, 138, 250, 119, 234, 165, 13, 16, 240, 120, 42, 91, 82, 7, 73, 86], [110, 38, 205, 93, 173, 103, 166, 20, 246, 236, 251, 127, 202, 201, 2, 154, 95, 167, 21, 80, 170, 246, 50, 204, 251, 88, 103, 6, 59, 90, 142, 248], [7, 60, 9, 109, 134, 79, 111, 120, 22, 200, 74, 187, 12, 157, 130, 80, 232, 99, 9, 72, 194, 18, 238, 213, 191, 212, 112, 156, 181, 52, 252, 142], [118, 252, 30, 168, 209, 70, 183, 124, 106, 249, 183, 250, 186, 169, 146, 119, 109, 14, 44, 9, 121, 164, 245, 121, 132, 74, 70, 139, 182, 52, 61, 114], [11, 124, 199, 185, 110, 186, 107, 120, 65, 211, 176, 238, 197, 58, 122, 253, 122, 11, 110, 51, 214, 167, 241, 104, 178, 115, 232, 90, 93, 82, 7, 236], [22, 209, 42, 109, 70, 39, 144, 56, 72, 115, 89, 106, 193, 104, 116, 246, 26, 12, 212, 44, 121, 181, 186, 166, 107, 29, 168, 23, 49, 180, 247, 92], [125, 63, 138, 228, 180, 4, 42, 127, 227, 188, 103, 58, 112, 80, 3, 24, 178, 103, 143, 45, 68, 170, 14, 85, 231, 167, 238, 51, 91, 116, 159, 63], [210, 236, 119, 196, 111, 47, 115, 208, 146, 37, 120, 215, 155, 10, 169, 5, 234, 155, 151, 28, 34, 13, 254, 63, 204, 134, 86, 81, 110, 105, 143, 175], [93, 66, 80, 192, 17, 202, 219, 246, 239, 31, 248, 71, 104, 140, 208, 17, 233, 143, 174, 8, 88, 133, 47, 88, 164, 100, 10, 59, 81, 150, 173, 85], [247, 141, 24, 101, 218, 128, 222, 159, 60, 186, 161, 207, 199, 159, 214, 184, 132, 239, 133, 174, 233, 223, 24, 203, 119, 229, 33, 15, 176, 0, 239, 154], [66, 177, 27, 240, 107, 219, 185, 225, 192, 253, 180, 72, 76, 234, 151, 148, 78, 193, 228, 132, 24, 229, 81, 247, 96, 184, 186, 139, 11, 72, 110, 103]}
    /Users/schwarzy/dev/status/nwakuslim/tests/waku_store_sync/test_protocol.nim(575, 28): Check failed: deliveredHashes notin outWinHashes
    deliveredHashes was 0xdd59...fb1d
    outWinHashes was {[132, 42, 134, 171, 48, 219, 243, 26, 63, 76, 67, 125, 220, 10, 128, 73, 64, 98, 163, 237, 194, 229, 60, 164, 193, 133, 54, 208, 128, 86, 163, 187], [208, 51, 233, 218, 115, 18, 167, 252, 137, 63, 89, 11, 1, 18, 109, 172, 103, 128, 117, 90, 171, 181, 213, 155, 101, 160, 79, 37, 162, 135, 2, 193], [123, 122, 57, 113, 1, 251, 195, 147, 72, 158, 246, 204, 86, 128, 2, 68, 253, 3, 110, 161, 223, 188, 116, 76, 159, 120, 168, 210, 110, 36, 178, 113], [111, 122, 159, 157, 55, 198, 46, 227, 55, 8, 204, 95, 29, 255, 143, 102, 69, 119, 117, 127, 89, 184, 137, 65, 239, 47, 224, 92, 198, 190, 141, 214], [207, 44, 107, 202, 38, 206, 233, 51, 122, 6, 221, 208, 30, 74, 91, 160, 52, 40, 61, 39, 126, 126, 16, 75, 139, 211, 99, 36, 48, 48, 59, 57], [77, 30, 189, 151, 252, 164, 1, 96, 50, 149, 241, 22, 3, 206, 9, 116, 131, 177, 108, 165, 80, 98, 139, 93, 203, 217, 227, 202, 0, 59, 248, 231], [202, 9, 172, 33, 233, 168, 89, 178, 1, 115, 120, 178, 208, 61, 189, 39, 144, 141, 112, 121, 105, 172, 49, 1, 199, 15, 91, 76, 215, 121, 167, 40], [43, 123, 225, 95, 227, 69, 23, 76, 172, 242, 32, 163, 45, 23, 140, 89, 227, 131, 71, 193, 130, 197, 69, 123, 194, 14, 213, 115, 182, 181, 142, 216], [22, 211, 224, 125, 189, 150, 130, 24, 138, 61, 103, 103, 195, 234, 231, 69, 12, 51, 147, 58, 183, 79, 119, 108, 255, 91, 241, 236, 139, 104, 250, 191], [253, 78, 177, 203, 84, 254, 247, 50, 170, 194, 75, 4, 253, 147, 192, 9, 157, 78, 141, 112, 244, 200, 131, 244, 111, 13, 199, 20, 20, 108, 150, 91], [251, 8, 5, 50, 120, 176, 197, 168, 103, 39, 192, 231, 54, 17, 64, 186, 173, 44, 24, 200, 12, 185, 229, 223, 186, 234, 117, 93, 165, 24, 13, 172], [23, 241, 156, 231, 241, 71, 126, 223, 223, 39, 78, 145, 88, 96, 52, 194, 31, 233, 66, 229, 248, 39, 228, 224, 40, 106, 161, 133, 59, 13, 111, 89], [29, 68, 43, 94, 121, 143, 137, 140, 149, 249, 224, 116, 68, 228, 81, 25, 160, 106, 50, 47, 167, 238, 125, 122, 97, 215, 110, 142, 244, 126, 148, 224], [97, 147, 199, 59, 39, 66, 251, 93, 147, 103, 249, 253, 240, 211, 174, 153, 57, 8, 196, 92, 25, 112, 79, 45, 123, 182, 243, 144, 185, 162, 210, 218], [123, 2, 79, 210, 87, 45, 96, 249, 126, 89, 142, 153, 198, 169, 190, 142, 128, 40, 209, 223, 200, 99, 156, 27, 143, 179, 17, 33, 41, 80, 157, 226], [102, 81, 249, 185, 161, 202, 155, 170, 133, 3, 105, 235, 112, 127, 238, 205, 70, 154, 113, 243, 84, 148, 178, 143, 238, 111, 205, 24, 239, 93, 50, 124], [180, 137, 35, 51, 27, 48, 15, 235, 88, 105, 9, 87, 247, 107, 59, 4, 175, 255, 42, 102, 115, 154, 3, 84, 79, 128, 208, 140, 205, 22, 238, 120], [221, 89, 144, 83, 176, 216, 167, 115, 82, 246, 44, 18, 38, 148, 168, 27, 195, 205, 132, 64, 44, 14, 81, 211, 171, 123, 139, 134, 247, 85, 251, 29], [126, 121, 91, 115, 51, 149, 153, 176, 163, 198, 110, 231, 14, 36, 243, 83, 129, 168, 65, 246, 176, 53, 207, 95, 155, 154, 218, 108, 79, 4, 174, 125], [193, 82, 202, 254, 43, 188, 149, 91, 138, 189, 198, 24, 213, 146, 131, 154, 29, 27, 242, 17, 10, 209, 73, 17, 170, 191, 84, 227, 104, 217, 255, 67]}

  [FAILED ] ( 300.0s) sync 2 nodes, 40 msgs: 18 in-window diff, 20 out-window ignored

I could reproduce it on my M4 Mac constantly. But as this coming not only for this PR, I decided to tackle it in a separate PR.

@NagyZoltanPeter
Copy link
Contributor

NagyZoltanPeter commented Oct 3, 2025

@Ivansete-status Why I cannot select you for review?

richard-ramos
richard-ramos approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Ivansete-status Ivansete-status merged commit 74b3770 into master Oct 3, 2025
14 of 16 checks passed
@Ivansete-status Ivansete-status deleted the fix-protocol-connection-close branch October 3, 2025 12:42
@Ivansete-status Ivansete-status mentioned this pull request Oct 8, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richard-ramos richard-ramos richard-ramos approved these changes

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: nwaku protocols does not use connection close consistently

3 participants

@Ivansete-status @NagyZoltanPeter @richard-ramos