Add in-repo API/e2e test suite (tests-e2e)#4027
Open
at0m1x19 wants to merge 2 commits into
Open
Conversation
|
You can find the image built from this PR at Built from 1f86e46 |
at0m1x19
marked this pull request as ready for review
July 14, 2026 18:16
at0m1x19
requested review from
AYAHASSAN287,
Ivansete-status,
fbarbu15 and
igor-sirotin
July 14, 2026 18:16
AYAHASSAN287
approved these changes
Jul 14, 2026
fbarbu15
approved these changes
Jul 15, 2026
| with service_result.ok_value as service: | ||
| service_multiaddr = get_node_multiaddr(service) | ||
|
|
||
| edge_config = build_node_config( |
Contributor
There was a problem hiding this comment.
don't we need relay=False here?
Author
There was a problem hiding this comment.
Good catch! added relay=False here, and to S26/S31 which had the same problem
Migrate the liblogosdelivery API/wrapper pytest suite into tests-e2e/ and run it in CI (e2e-api-tests.yml) against the built library. Edge senders use the real lightpush path (relay=False).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates the
liblogosdeliveryAPI e2e "wrapper" suite (framework + ~21 tests) fromlogos-delivery-interop-testsintotests-e2e/, and runs it in CI against the library built by thebuildjob.For reviewers
The diff is ~6k lines, but only ~100 are new or specific to this repo. Everything under
tests-e2e/src/, the other test files, the binding and the config are byte-for-byte copies fromlogos-delivery-interop-tests(already reviewed there).Please review these (new / repo-specific):
.github/workflows/e2e-api-tests.ymlliblogosdeliveryartifact frombuild, runs the non-docker subset.github/workflows/ci.ymlsend-api-e2e-testsnow calls the in-repo workflow (was remotesend_api_e2e_PR.yml@SMOKE_TEST_…);tests-e2e/**added to thechangesfiltertests-e2e/scripts/prepare_lib.shliblogosdeliveryand places it where the binding expects ittests-e2e/README.mdtests-e2e/tests/wrappers_tests/test_send_e2e_part2.pyThe one test change (
test_send_e2e_part2.py)Three tests fixed and their stale
#3847xfails removed (the bug is fixed by #3967 — these were test defects, not product bugs):relay=Falseto the "Edge" sender.build_node_config()defaultsrelay=True, which maskedmode="Edge", so the senders delivered via relay instead of lightpush.relay=Falsemakes them exercise the real lightpush path.lightpushnode(the previously commented-out config parses fine on master).Why
Tests live next to the code they cover: a library change and its e2e test land in the same PR, validated against the exact library that PR builds — no cross-repo tag pin.
Result (this PR's CI)
send-api-e2e-tests / api-e2e: 18 passed, 3 docker-only deselected, 0 xfailed (~7 min), against a freshly builtliblogosdelivery.Follow-ups
logos-delivery-interop-tests.