fix: have better defaults for send/recv rate-limits #1267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
changed the title
kaichaosun
approved these changes
Dec 16, 2024
plopezlpz
approved these changes
Dec 16, 2024
chaitanyaprem
force-pushed
the
fix/rate-limits
branch
from
e21beb9 to
122e9de
Compare
richard-ramos
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
have better defaults for send/recv rate-limits to accomodate status use-case
default rate-limits set for publishing and filter client receiving is not sufficient for status and is causing message reliability issues like status-im/status-legacy#21809 (comment).
Changes
note that i have given higher bursts so that there is room for occasional bursts.