ci: fix linter, storev3 tests and nix-flake jobs #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
force-pushed
the
chore/upgrade-go-1.23
branch
from
ec1a3f7 to
39b5aa3
Compare
Jenkins BuildsClick to see older builds (3)
|
igor-sirotin
force-pushed
the
chore/upgrade-go-1.23
branch
from
39b5aa3 to
ea00264
Compare
igor-sirotin
requested review from
chaitanyaprem and
richard-ramos
as code owners
igor-sirotin
changed the title
This was a hack-fix for actual issue which was simply that the multibranch pipeline was not fetching submodules when cloning. Signed-off-by: Jakub Sokołowski <[email protected]>
igor-sirotin
changed the title
jakubgs
approved these changes
Aug 25, 2025
richard-ramos
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lintto v1.64.6nwakuversion used in storev3 tests, otherwise they fail. Upgrading to the latest one is probably not reasonable for this purpose.nix-flakejob fix by @jakubgs from https://github.com/waku-org/go-waku/pull/1290/commitsRequired for #1288