Skip to content

chore: upgrade to go 1.23 #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igor-sirotin merged 4 commits into from
Aug 25, 2025
Merged

chore: upgrade to go 1.23 #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0f3cd4
feat(Makefile): mod tidy examples
igor-sirotin Aug 25, 2025
82962bd
chore(nix): ugprade Go from 1.21 to 1.23
jakubgs Aug 25, 2025
1c64d49
chore: upgrade to Go 1.23
igor-sirotin Aug 25, 2025
732bcf3
ci: upgrade nix to 24.11
igor-sirotin Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# BUILD IMAGE --------------------------------------------------------
FROM golang:1.21 as builder
FROM golang:1.23 as builder

WORKDIR /app
COPY . .
Expand Down
7 changes: 7 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ chat2:

vendor:
${GOCMD} mod tidy
cd examples/basic-light-client && ${GOCMD} mod tidy
cd examples/basic-relay && ${GOCMD} mod tidy
cd examples/chat2-reliable && ${GOCMD} mod tidy
cd examples/chat2 && ${GOCMD} mod tidy
cd examples/filter2 && ${GOCMD} mod tidy
cd examples/noise && ${GOCMD} mod tidy
cd examples/rln && ${GOCMD} mod tidy

lint-install:
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | \
Expand Down
2 changes: 1 addition & 1 deletion default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
version ? builtins.readFile ./VERSION,
}:

pkgs.buildGo121Module {
pkgs.buildGo123Module {
name = "go-waku";
src = self;

Expand Down
4 changes: 1 addition & 3 deletions examples/basic-light-client/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module basic2

go 1.21

toolchain go1.21.10
go 1.23

replace github.com/waku-org/go-waku => ../..

Expand Down
4 changes: 1 addition & 3 deletions examples/basic-relay/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module basic2

go 1.21

toolchain go1.21.10
go 1.23

replace github.com/waku-org/go-waku => ../..

Expand Down
5 changes: 2 additions & 3 deletions examples/chat2-reliable/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module chat2-reliable

go 1.21

toolchain go1.21.10
go 1.23

replace github.com/waku-org/go-waku => ../..

Expand Down Expand Up @@ -74,6 +72,7 @@ require (
github.com/ipfs/go-cid v0.4.1 // indirect
github.com/jackpal/go-nat-pmp v1.0.2 // indirect
github.com/jbenet/go-temp-err-catcher v0.1.0 // indirect
github.com/jellydator/ttlcache/v3 v3.3.0 // indirect
github.com/klauspost/compress v1.17.9 // indirect
github.com/klauspost/cpuid/v2 v2.2.8 // indirect
github.com/koron/go-ssdp v0.0.4 // indirect
Expand Down
2 changes: 2 additions & 0 deletions examples/chat2-reliable/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,8 @@ github.com/jbenet/go-temp-err-catcher v0.1.0 h1:zpb3ZH6wIE8Shj2sKS+khgRvf7T7RABo
github.com/jbenet/go-temp-err-catcher v0.1.0/go.mod h1:0kJRvmDZXNMIiJirNPEYfhpPwbGVtZVWC34vc5WLsDk=
github.com/jedisct1/go-minisign v0.0.0-20190909160543-45766022959e/go.mod h1:G1CVv03EnqU1wYL2dFwXxW2An0az9JTl/ZsqXQeBlkU=
github.com/jellevandenhooff/dkim v0.0.0-20150330215556-f50fe3d243e1/go.mod h1:E0B/fFc00Y+Rasa88328GlI/XbtyysCtTHZS8h7IrBU=
github.com/jellydator/ttlcache/v3 v3.3.0 h1:BdoC9cE81qXfrxeb9eoJi9dWrdhSuwXMAnHTbnBm4Wc=
github.com/jellydator/ttlcache/v3 v3.3.0/go.mod h1:bj2/e0l4jRnQdrnSTaGTsh4GSXvMjQcy41i7th0GVGw=
github.com/jessevdk/go-flags v0.0.0-20141203071132-1679536dcc89/go.mod h1:4FA24M0QyGHXBuZZK/XkWh8h0e1EYbRYJSGM75WSRxI=
github.com/jmespath/go-jmespath v0.4.0/go.mod h1:T8mJZnbsbmF+m6zOOFylbeCJqk5+pHWvzYPziyZiYoo=
github.com/jmespath/go-jmespath/internal/testify v1.5.1/go.mod h1:L3OGu8Wl2/fWfCI6z80xFu9LTZmf1ZRjMHUOPmWr69U=
Expand Down
4 changes: 1 addition & 3 deletions examples/chat2/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module chat2

go 1.21

toolchain go1.21.10
go 1.23

replace github.com/waku-org/go-waku => ../..

Expand Down
4 changes: 1 addition & 3 deletions examples/filter2/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module filter2

go 1.21

toolchain go1.21.10
go 1.23

replace github.com/waku-org/go-waku => ../..

Expand Down
4 changes: 1 addition & 3 deletions examples/noise/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module noise

go 1.21

toolchain go1.21.10
go 1.23

replace github.com/waku-org/go-waku => ../..

Expand Down
4 changes: 1 addition & 3 deletions examples/rln/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module rln

go 1.21

toolchain go1.21.10
go 1.23

replace github.com/waku-org/go-waku => ../..

Expand Down
8 changes: 4 additions & 4 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
description = "Nix flake for Go implementaion of Waku v2 node.";

inputs.nixpkgs.url = github:NixOS/nixpkgs/nixos-23.11;
inputs.nixpkgs.url = github:NixOS/nixpkgs/nixos-24.11;

outputs = { self, nixpkgs }:
let
Expand Down
8 changes: 3 additions & 5 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
module github.com/waku-org/go-waku

go 1.21

toolchain go1.21.10
go 1.23

replace github.com/ethereum/go-ethereum v1.10.26 => github.com/status-im/go-ethereum v1.10.25-status.15

replace github.com/libp2p/go-libp2p-pubsub v0.12.0 => github.com/waku-org/go-libp2p-pubsub v0.12.0-gowaku.0.20240823143342-b0f2429ca27f

require (
github.com/btcsuite/btcd/btcec/v2 v2.2.1
github.com/btcsuite/btcd/btcec/v2 v2.2.1 // indirect
github.com/cruxic/go-hmac-drbg v0.0.0-20170206035330-84c46983886d
github.com/ethereum/go-ethereum v1.10.26
github.com/golang-migrate/migrate/v4 v4.15.2
Expand Down Expand Up @@ -112,7 +110,7 @@ require (
github.com/cpuguy83/go-md2man/v2 v2.0.4 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/davidlazar/go-crypto v0.0.0-20200604182044-b73af7476f6c // indirect
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.3.0 // indirect
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.3.0
github.com/docker/go-units v0.5.0 // indirect
github.com/elastic/gosigar v0.14.3 // indirect
github.com/flynn/noise v1.1.0 // indirect
Expand Down
Loading