Skip to content

Conversation

@chaitanyaprem
Copy link
Contributor

Description

Trying to provide a config to enable loglevel per topic.

Noticed a weird issue where while trying to set loglevel using the config it fails if the topics have spaces in them e.g "waku mix" and works without any issues when using wakumix without spaces.
Not sure if it is a bug in chronicles or something else.

Also i was not able to set the logLevel for underlying mix protocol code eventhough i have specified a topic name. Need to debug this.

Changes

Issue

@chaitanyaprem chaitanyaprem changed the base branch from master to mix/static-mix-nodes October 3, 2025 09:59
@chaitanyaprem chaitanyaprem changed the title chore: topic log level config chore: provide an option to specify log level per topic Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3611

Built from 066a5b1

@Ivansete-status
Copy link
Collaborator

Thanks for the PR @chaitanyaprem . Nevertheless, I'm not super convinced this is needed :)
I'd explore other options first and maybe double-check whether there's an issue in nim-chronicles.
The log level should be the same in the whole app/lib. We can't have such complex mixture of loglevels.

@chaitanyaprem
Copy link
Contributor Author

Thanks for the PR @chaitanyaprem . Nevertheless, I'm not super convinced this is needed :)

well, i think this would be a very useful feature for debugging. Becase right now if i enable trace level globally and want to debug there is a flood of logs and it becomes hard to filter things out especially when logs keep filling up disk space.
With a topic level config, we can debug specific module we are developing especially when testing with TWN etc we can ask node runners to just enable TRACE level for a certain module.

@Ivansete-status
Copy link
Collaborator

well, i think this would be a very useful feature for debugging. Becase right now if i enable trace level globally and want to debug there is a flood of logs and it becomes hard to filter things out especially when logs keep filling up disk space. With a topic level config, we can debug specific module we are developing especially when testing with TWN etc we can ask node runners to just enable TRACE level for a certain module.

ah okay I see, makes sense indeed.
Did you try setting chronicles_enabled_topics compilation flag? I think so as per the PR's description but not sure. I think I would go through that direction, if possible :)

@chaitanyaprem chaitanyaprem force-pushed the chore/topic-log-level-config branch from 3b596ed to e6e28c7 Compare October 7, 2025 07:02
Base automatically changed from mix/static-mix-nodes to master October 8, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants