Skip to content

removing mix repo as dependency and using mix from libp2p repo #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaitanyaprem merged 3 commits into from
Oct 23, 2025
Merged

removing mix repo as dependency and using mix from libp2p repo #3632

chaitanyaprem merged 3 commits into from
Oct 23, 2025

Conversation

@chaitanyaprem
Copy link
Contributor

@chaitanyaprem chaitanyaprem commented Oct 21, 2025 •
edited
Loading

Description

Remove separate mix dependency and use the mix version that is part of nim-libp2p.
Had to make min version 1.14.2 as there was a fix done in mix without which waku-mix won't compile.

Deliverable: #3617

Changes

Issue

closes #

@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3632

Built from 3ed276f

jm-clius
jm-clius approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave decision on when to merge up to you, but LGTM

NagyZoltanPeter
NagyZoltanPeter approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Only one small remark I had, if you may find it useful.
Do you think we need this into release under preparation?

@chaitanyaprem
Copy link
Contributor Author

chaitanyaprem commented Oct 23, 2025

Do you think we need this into release under preparation?

Not sure as this only changes usage of mix in libp2p rather than separate dependency. Maybe @fryorcraken can comment if this is needed.

@chaitanyaprem chaitanyaprem merged commit 8be4518 into master Oct 23, 2025
7 of 8 checks passed
@chaitanyaprem chaitanyaprem deleted the chore/remove-mix-dep branch October 23, 2025 04:30
@fryorcraken
Copy link
Collaborator

fryorcraken commented Oct 24, 2025

Do you think we need this into release under preparation?

Not sure as this only changes usage of mix in libp2p rather than separate dependency. Maybe @fryorcraken can comment if this is needed.

Well, I still cannot make a clean usage of nimble with nwaku (see https://discord.com/channels/864066763682218004/1430384784294547542/1430775598745387028 on Vac Discord). So the removal of any nimble related complexity is welcome.

darshankabariya pushed a commit that referenced this pull request Nov 13, 2025
@chaitanyaprem @darshankabariya
removing mix repo as dependency and using mix from libp2p repo (#3632)
0c15a1b 
* use released version of libp2p 1.14.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jm-clius jm-clius jm-clius approved these changes

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@fryorcraken fryorcraken Awaiting requested review from fryorcraken

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees

@chaitanyaprem chaitanyaprem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chaitanyaprem @fryorcraken @jm-clius @NagyZoltanPeter