-
Notifications
You must be signed in to change notification settings - Fork 78
chore: pin rln dependencies to specific version #3649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stubbsta
wants to merge
8
commits into
master
Choose a base branch
from
chore/pin-rln-dependencies-versions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 862fa4b |
Contributor
Author
|
TODO:
|
NagyZoltanPeter
approved these changes
Dec 10, 2025
Contributor
NagyZoltanPeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is ok, as long as we trust newer versions of those tools :-)
36ff7a6 to
2ae26b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to add specific versions of the RLN dependencies that are verified to work with the waku-rlnv2-contract. This is used for contract deployment and interactions in ci tests.
Foundry/Anvil/Force dependency:
Most of the RLN related tests require a local testnet. We install foundry's anvil for this.
If anvil is already installed then that version is used or we have a script which will install the latest version.
pnpm dependency
We deploy the waku-rlnv2-contract from the contract repo as part of RLN tests. To build the contract locally we require pnpm.
Currently if pnpm is not installed, we install the latest version.
Changes
Issue
Relates to #3643