feat(tests): robustify waku_rln_relay test utils #3650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 3923896 |
Ivansete-status
approved these changes
Nov 28, 2025
Collaborator
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
LGTM! Thanks for it! 🙌
Kindly link this PR with maintenance issue ( notice the bidirectional linkage, that allows navigating from each other .)
Collaborator
|
@weboko - I'm afraid the js-waku-node failure isn't related to these changes, right? |
Contributor
Author
I remember the js-waku tests were failing for me in my isOkOr refactor (that changed nothing). When I re-ran them, they passed. Re-running them now. EDIT: Passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
ETH_FROMorETH_PASSWORDenv vars are set before running unit tests (for example, you set these in~/.bashrc...🤦♀️) the RLN tests loop forever with 100% CPU due to a failed forge script invocation. This leaves an orphaned anvil instance which hogs the localhost:8540 port, which makes the next anvil launch attempt to loop forever due to port already in use.Changes
ETH_FROMandETH_PASSWORDbefore runningforge scriptso that it isn't misconfigured and failsWorkaround
Don't set
ETH_FROMandETH_PASSWORDin the environment you're using to run unit tests.Issue
Maintenance Y2025H2 #3483