Chore: bump waku-rlnv2-contract-repo commit

[stubbsta]

Description

Bumping waku-rlnv2-contract repo to latest commit. This is to fix the CI tests getting stuck on contract deployment.

Changes

Use waku-rlnv2-contract commit 8a338f354481e8a3f3d64a72e38fad4c62e32dcd
The updated contract emits additional events at registration. The method of retrieving the Membership registered event was updated in the group_manager.

Related Issue

closes #3654

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3651

Built from f1c9b9b

[stubbsta]

related issue: #3654

[stubbsta]

TODO:

• Add test to deploy contracts and dump state file - to be used when there are updates to the contract repo
• Add new runAnvil params to all tests that use it

[Ivansete-status]

LGTM! Thanks so much indeed! 💯 🥳

I'm adding some nitpicks that I hope you find useful.

Also:

• Kindly link this PR with maintenance issue (see how other are linked.)

• If possible, it would be interesting to push the tests/waku_rln_relay/anvil_state/state-deployed-contracts-mint-and-approved.json file zipped/compressed so that we keep the repo small when cloning

• I think is also interesting to reduce the timeout-minutes: 90 to 45 in .github/workflows/ci.yml

[Ivansete-status]

If possible, let's better use valueOr or isOkOr :)

Suggested change

	if membershipRegisteredLog.isNone():
	raise newException(
	ValueError, "register: MembershipRegistered event not found in transaction logs"
	)
	let registrationLog = membershipRegisteredLog.get()
	let registrationLog = membershipRegisteredLog.valueOr:
	raise newException(
	ValueError, "register: MembershipRegistered event not found in transaction logs"
	)

[stubbsta]

If possible, let's better use valueOr or isOkOr :)

The membershipRegisteredLog is of type Option which doesn't seem to work with valueOr or isOkOr, they work with Result
It doesn't quite make sense to me to make membershipRegisteredLog of type Result.
I'll try to see if this section of code can be reworked to fit the required coding style better.

[fcecin]

LGTM

[stubbsta]

This PR addresses this issue #3654

[stubbsta]

• If possible, it would be interesting to push the tests/waku_rln_relay/anvil_state/state-deployed-contracts-mint-and-approved.json file zipped/compressed so that we keep the repo small when cloning

@Ivansete-status what would be the preferred workflow for unzipping?

• Do we have the runAnvil proc check whether the given file is zipped and unzip as needed?
• Do we add a section to the make file to unzip as part of the rln-deps section?
  something like this:

rln-deps: rustup
	./scripts/install_rln_tests_dependencies.sh

# Decompress anvil state file for testing
anvil-state: tests/waku_rln_relay/anvil_state/anvil_state.json

tests/waku_rln_relay/anvil_state/anvil_state.json: tests/waku_rln_relay/anvil_state/anvil_state.json.gz
	@echo "Decompressing anvil state file..."
	@gunzip -c tests/waku_rln_relay/anvil_state/anvil_state.json.gz > tests/waku_rln_relay/anvil_state/anvil_state.json

deps: | deps-common nat-libs waku.nims anvil-state

• Do we run the unzip at the start of a test suite so it only needs to be done once for a test suit instead of every time runAnvil is called?

[Ivansete-status]

This is the best option IMO:

• runAnvil proc check whether the given file is zipped and unzip as needed

[stubbsta]

This is the best option IMO:

• runAnvil proc check whether the given file is zipped and unzip as needed

Implemented in 206b7d5

[stubbsta]

@Ivansete-status and @fcecin please review latest changes.
Then regarding this comment: #3651 (comment)
I think this is better addressed in the issue #3645 (avoid raise exception from within group_manager) as I see it as part of updating the file to better follow the nim style/formatting used in the repo.

[stubbsta]

@fcecin do you perhaps know why the ci tests are again not running?

[fcecin]

@fcecin do you perhaps know why the ci tests are again not running?

EDIT 2: Actually it's an error:

[Invalid workflow file: .github/workflows/ci.yml#L140](https://github.com/logos-messaging/nwaku/actions/runs/19966186883/workflow)
error parsing called workflow
".github/workflows/ci.yml"
-> "logos-messaging/waku-interop-tests/.github/workflows/nim_waku_PR.yml@SMOKE_TEST_0.0.1"
: workflow was not found. See https://docs.github.com/actions/learn-github-actions/reusing-workflows#access-to-reusable-workflows for more information.

https://github.com/logos-messaging/nwaku/actions/runs/19966186883

EDIT 3: I think the "waku" name is being nuked on other places so logos-messaging/waku-interop-tests/ is now https://github.com/logos-messaging/logos-messaging-interop-tests

[stubbsta]

Relates to milestone #3483

[Ivansete-status]

Superb! Thanks so much for it! 🥳