feat: DAI permit #26
Open
feat: DAI permit #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
requested review from
0x-r4bbit,
danisharora099,
s-tikhomirov and
stubbsta
0x-r4bbit
approved these changes
Jul 16, 2025
0x-r4bbit
left a comment
0x-r4bbit
left a comment
There was a problem hiding this comment.
Very nice work @richard-ramos !
Sorry for the long wait (I was out for a couple of weeks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that DAI permit function and EIP-2612 are different.
This adds a permit specific for DAI, and a minor optimization in the parameters for
caling the register to avoid a stack-too-deep error due to using too many vars