Adapt for nwaku v0.35 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to adapt to nwaku changes
Closed
Ivansete-status
requested review from
NagyZoltanPeter,
darshankabariya and
gabrielmer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 62.64% 57.76% -4.89%
==========================================
Files 18 21 +3
Lines 1791 1153 -638
==========================================
- Hits 1122 666 -456
+ Misses 669 487 -182 ☔ View full report in Codecov by Sentry. |
NagyZoltanPeter
approved these changes
Feb 12, 2025
NagyZoltanPeter
left a comment
NagyZoltanPeter
left a comment
There was a problem hiding this comment.
LGTM, nitpick that for nwaku eyes ;-) naming vendor_path makes confusion.
waku-sys/build.rs
Outdated
| .success() | ||
| { | ||
| // Now, inside nwaku folder, run 'make update' to get nwaku's vendors | ||
| let vendor_path = project_dir.join("vendor"); |
There was a problem hiding this comment.
maybe better call it nwaku_path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waku-bindings/src/general/messagehash.rsso that we handle waku message hashes as strings instead of byte[32]waku-sys/build.rsso that the submodule is automatically initialized once and adapt to new parameter usage in nwaku's MakefileIssue