Remove contentFrame from Client #29
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the
convo.sendMessageandonNewMessageassume content is formatted as a ContentFrame. As contentFrames are an independent/optional protocol the chat sdk should not require them. ref: #21Solution
This PR defines a type (
Content) asseq[byte]and updates all functions to use it. Clients now expectseq[bytes]as input messages.Note
sendMessageand callback. Handling it automatically within the api would improve the developer experience. This caused issues within the type system and will require more work. Pushing this step for now.