feat: dns discovery bootstrap #35
Open
+68
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaichaosun
force-pushed
the
nwaku-discovery
branch
from
fb97ec8 to
76e65f4
Compare
Collaborator
|
Here is the output from |
Collaborator
|
It appears that the client is attempting to parse all messages, and the traffic from status is not WapEnvelope wrapped which is leading to decoding errors. Looks like we'll need to:
|
jazzz
reviewed
Dec 3, 2025
| await raya.start() | ||
|
|
||
| await sleepAsync(5.seconds) | ||
| await sleepAsync(10.seconds) |
Collaborator
There was a problem hiding this comment.
In the TUI example, you changed all durations to chronos.seconds(10). Which is the preferable form? That way I can make my future code consistent
Contributor
Author
There was a problem hiding this comment.
In TUI example, the times library is conflict with chronos, so the prefix is needed, 5.seconds seems preferable if no conflict happens.
Collaborator
There was a problem hiding this comment.
jazzz
reviewed
Dec 4, 2025
| import chronos | ||
| import illwill | ||
| import libp2p/crypto/crypto | ||
| import times |
Collaborator
There was a problem hiding this comment.
You could avoid the conflict between chronos and times - though not the cleanest
Suggested change
| from times import DateTime, format, now, `<` |
Contributor
Author
There was a problem hiding this comment.
Looks not clean to me, let's stick to the current one. I won't bother too much as we are switching language soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works but not stable, I have encountered stability issues with discovery, likely because the state firewall and vpn.
Fix such experience should be handled in nwaku.
Can you also test tui and pingpong example and see if it's acceptable? @jazzz
Changes:
Fix: #17