first ci version#12
Merged
Merged
Conversation
Ivansete-status
requested review from
NagyZoltanPeter,
darshankabariya and
fcecin
April 27, 2026 22:04
fcecin
approved these changes
Apr 28, 2026
gmelodie
reviewed
Apr 28, 2026
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] |
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| nim-version: ['2.2.4', 'stable'] |
Collaborator
There was a problem hiding this comment.
nit: maybe 2.2.10 too? Or dev
gmelodie
reviewed
Apr 28, 2026
| run: nimble install -y --depsOnly | ||
|
|
||
| - name: Build | ||
| run: nimble build -y |
Collaborator
There was a problem hiding this comment.
The error on 2.2.4 seems to come from the --noMain flag in ffi.nimble (maybe removing it will fix the issue? Not sure why that's there though)
Ivansete-status
force-pushed
the
enhance-ci-2
branch
from
April 29, 2026 13:33
7665cc5 to
ac6940e
Compare
gmelodie
approved these changes
Apr 29, 2026
gmelodie
left a comment
gmelodie
left a comment
Collaborator
There was a problem hiding this comment.
No desperate need to run devel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.