Skip to content

chore: remove CatchableError #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmelodie merged 1 commit into from
May 8, 2026
Merged

chore: remove CatchableError #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ffi/ffi_context.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ proc processRequest[T](
let res =
try:
await retFut
except CatchableError as exc:
Result[string, string].err("Exception in processRequest for " & reqId & ": " & exc.msg)
except AsyncError as exc:
Result[string, string].err("Async error in processRequest for " & reqId & ": " & exc.msg)

## handleRes may raise (OOM, GC setup) even though it is rare. Catching here
## keeps the async proc raises:[] compatible. The defer inside handleRes
Expand Down
4 changes: 2 additions & 2 deletions ffi/logging.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ proc writeAndFlush(f: syncio.File, s: LogOutputStr) =
try:
f.write(s)
f.flushFile()
except CatchableError:
except IOError:
logLoggingFailure(cstring(s), getCurrentException())

## Setup
Expand Down Expand Up @@ -99,7 +99,7 @@ proc setupLog*(level: LogLevel, format: LogFormat) =
let color =
try:
not parseBool(os.getEnv("NO_COLOR", "false"))
except CatchableError:
except ValueError:
true

setupLogLevel(level)
Expand Down
Loading