Skip to content

chore(ci): add nph linting#77

Merged
gmelodie merged 5 commits into
masterfrom
chore/ci/nph
Jun 10, 2026
Merged

chore(ci): add nph linting#77
gmelodie merged 5 commits into
masterfrom
chore/ci/nph

Conversation

@gmelodie

@gmelodie gmelodie commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Closes #76.

Summary

  • Adds .github/workflows/linters.yml running arnetheduck/nph-action@v1 at nph v0.7.0 with fail: true and suggest: true. Triggers on pull_request and merge_group; concurrency group cancels superseded runs per PR/branch.
  • Reformats existing .nim / .nims / .nimble sources with nph 0.7.0 so the new check passes against the current tree (12 files touched, 22 left as-is).

Based on nim-libp2p's linters workflow. Skipped the clang-format step (no cbind/ and no .clang-format in this repo) and the skywalking-eyes license-header step (no .github/.licenserc.yaml and no per-file headers). Easy to bolt on later.

@gmelodie
gmelodie requested a review from Ivansete-status June 8, 2026 11:25
@gmelodie
gmelodie marked this pull request as ready for review June 8, 2026 11:25

@Ivansete-status Ivansete-status left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🥳

@gmelodie
gmelodie merged commit 16dc1b3 into master Jun 10, 2026
83 checks passed
@gmelodie
gmelodie deleted the chore/ci/nph branch June 10, 2026 19:30
gmelodie added a commit that referenced this pull request Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

start using nph

2 participants