Skip to content

chore: reduce terminal log noise #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shash256 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: reduce terminal log noise #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e8185
chore: reduce terminal log noise
shash256 Aug 18, 2025
f2cfd04
feat: add file logging
shash256 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion library/libsds.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,23 @@ proc libsdsNimMain() {.importc.}
# To control when the library has been initialized
var initialized: Atomic[bool]

if defined(android):
when defined(android):
# Redirect chronicles to Android System logs
when compiles(defaultChroniclesStream.outputs[0].writer):
defaultChroniclesStream.outputs[0].writer = proc(
logLevel: LogLevel, msg: LogOutputStr
) {.raises: [].} =
echo logLevel, msg
else:
# For non-android, configure Chronicles with a null writer to suppress logs
# or redirect to a proper logging mechanism
when compiles(defaultChroniclesStream.outputs[0].writer):
defaultChroniclesStream.outputs[0].writer = proc(
logLevel: LogLevel, msg: LogOutputStr
) {.raises: [].} =
# Only log ERROR and FATAL levels to reduce verbosity
if logLevel >= LogLevel.ERROR:
echo "[nim-sds] ", logLevel, ": ", msg

proc initializeLibrary() {.exported.} =
if not initialized.exchange(true):
Expand Down
2 changes: 1 addition & 1 deletion library/sds_thread/inter_thread_communication/requests/sds_message_request.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ proc process*(
let messageBytes = self.message.toSeq()

let (unwrappedMessage, missingDeps, channelId) = unwrapReceivedMessage(rm[], messageBytes).valueOr:
error "UNWRAP_MESSAGE failed", error = error
debug "UNWRAP_MESSAGE failed", error = error
Copy link

@kaichaosun kaichaosun Aug 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the log lives? Would be great to make it consistent with status-go, which lives in a log file.

return err("error processing UNWRAP_MESSAGE request: " & $error)

let res = SdsUnwrapResponse(message: unwrappedMessage, missingDeps: missingDeps, channelId: channelId)
Expand Down
6 changes: 3 additions & 3 deletions src/reliability.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ proc reviewAckStatus(rm: ReliabilityManager, msg: SdsMessage) {.gcsafe.} =
)
)
else:
error "Failed to deserialize bloom filter", error = bfResult.error
debug "Failed to deserialize bloom filter", error = bfResult.error
rbf = none[RollingBloomFilter]()
else:
rbf = none[RollingBloomFilter]()
Expand Down Expand Up @@ -106,7 +106,7 @@ proc wrapOutgoingMessage*(

let bfResult = serializeBloomFilter(channel.bloomFilter.filter)
if bfResult.isErr:
error "Failed to serialize bloom filter", channelId = channelId
debug "Failed to serialize bloom filter", channelId = channelId
return err(ReliabilityError.reSerializationError)

let msg = SdsMessage(
Expand Down Expand Up @@ -230,7 +230,7 @@ proc unwrapReceivedMessage*(

return ok((msg.content, missingDeps, channelId))
except Exception:
error "Failed to unwrap message", msg = getCurrentExceptionMsg()
debug "Failed to unwrap message", msg = getCurrentExceptionMsg()
return err(ReliabilityError.reDeserializationError)

proc markDependenciesMet*(
Expand Down
4 changes: 2 additions & 2 deletions src/rolling_bloom_filter.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ proc clean*(rbf: var RollingBloomFilter) {.gcsafe.} =

# Initialize new filter
var newFilter = initializeBloomFilter(rbf.maxCapacity, rbf.filter.errorRate).valueOr:
error "Failed to create new bloom filter", error = $error
debug "Failed to create new bloom filter", error = $error
return

# Keep most recent messages up to minCapacity
Expand All @@ -93,7 +93,7 @@ proc clean*(rbf: var RollingBloomFilter) {.gcsafe.} =
rbf.messages = newMessages
rbf.filter = newFilter
except Exception:
error "Failed to clean bloom filter", error = getCurrentExceptionMsg()
debug "Failed to clean bloom filter", error = getCurrentExceptionMsg()

proc add*(rbf: var RollingBloomFilter, messageId: SdsMessageID) {.gcsafe.} =
## Adds a message ID to the rolling bloom filter.
Expand Down