add config option for messageIsLine#64
Open
cskiraly wants to merge 1 commit into
Open
Conversation
easily switch between small (segment) messages and large (row/column) messages Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
leobago
reviewed
Mar 26, 2024
| messageIsLine = False | ||
| if messageIsLine: | ||
| # Message is line | ||
| perNodeQueue = "self.amIproposer" # keep a global queue of incoming messages for later sequential dispatch |
Collaborator
There was a problem hiding this comment.
Not sure to understand this option here. Why would the block proposer need this here and the others not?
Contributor
Author
There was a problem hiding this comment.
it's not too intuitive, I know, but it is related to how we prepare the block for being pushed out from the proposer(producer): queueAllOnInit only influences the the proposer(producer). We need the perNodeQueue for queueAllOnInit to function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
easily switch between small (segment) messages and large (row/column) messages
This adds the messageIsLine meta config parameter which switch a number of scheduling options together.
Default is kept like before, with small messages