Track logstash versions in .ci #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously logstash versions were tracked in the logstash repo and curled during CI steps. This commit moves the source of truth to the `.ci` repo where the consumer of that information lives. This also changes the format from json to yaml to allow commenting in the file.
donoghuc
force-pushed
the
move-releases-file
branch
from
f8acf3b to
4049b16
Compare
donoghuc
added a commit
to donoghuc/logstash-output-elasticsearch
that referenced
this pull request
Aug 6, 2025
Temporarily include logstash-versions until logstash-plugins/.ci#77 is merged.
donoghuc
added a commit
to donoghuc/logstash-integration-rabbitmq
that referenced
this pull request
Aug 6, 2025
Temporarily include logstash-versions until logstash-plugins/.ci#77 is merged.
mashhurs
approved these changes
Aug 6, 2025
Contributor
mashhurs
left a comment
mashhurs
left a comment
There was a problem hiding this comment.
LGTM!
Let's remove the "CODEREVIEW" comment(s).
donoghuc
added a commit
to logstash-plugins/logstash-output-elasticsearch
that referenced
this pull request
Aug 7, 2025
* Track logstash versions in .ci Previously logstash versions were tracked in the logstash repo and curled during CI steps. This commit moves the source of truth to the `.ci` repo where the consumer of that information lives. This also changes the format from json to yaml to allow commenting in the file. * REMOVE THIS COMMIT Temporarily include logstash-versions until logstash-plugins/.ci#77 is merged. * Fix path to logstash-releases.yaml * Code review resolution * Revert "REMOVE THIS COMMIT" This reverts commit 2aadeda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously logstash versions were tracked in the logstash repo and curled during CI steps. This commit moves the source of truth to the
.cirepo where the consumer of that information lives. This also changes the format from json to yaml to allow commenting in the file.We will want to make sure that projects that override this are also updated:
[ ] https://github.com/logstash-plugins/logstash-input-jdbc/blob/878a73eb67b68366fac74fcc65e9cadd6cf44766/ci/unit/docker-setup.sh#L7Outdated plugin, does not seem to be running tests.[ ] https://github.com/logstash-plugins/logstash-filter-jdbc_streaming/blob/2ed23b51c0b9b1a57e39bf672f6f013eae88d5fc/ci/unit/docker-setup.sh#L7Outdated plugin, does not seem to be running tests.