[CI] fix vendor download #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
approved these changes
Oct 29, 2025
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Good alternative to minitar using our rake pattern for invoking a vendor task. ✅
jsvd
reviewed
Oct 29, 2025
Member
jsvd
left a comment
jsvd
left a comment
There was a problem hiding this comment.
As mentioned over slack, I'd rather we fix the logstash-devutils task otherwise it stays broken, potentially for other plugins too.
But I'll leave the call up to you.
Contributor
Author
|
Thank you both for reviewing this. I have searched the repo and confirmed that only this plugin uses the vendor rake task. So, we are good to move away from devutils |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bash script to download types.db instead of devutils vendor rake task
Fix: Collectd codec minitar not found https://app.travis-ci.com/github/logstash-plugins/logstash-codec-collectd/jobs/636123873?serverType=git
How to test this PR
bundle install && bundle exec rake vendor
types.db should be in ./vendor