Doc: Add space delimited URI examples to hosts option#149
Open
karenzone wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Replaces #146 |
karenzone
force-pushed
the
exp-env-var2
branch
from
bf58940 to
2756b6d
Compare
karenzone
force-pushed
the
exp-env-var2
branch
from
7c482f3 to
637b5e2
Compare
kares
reviewed
Aug 16, 2021
kares
left a comment
kares
left a comment
Contributor
There was a problem hiding this comment.
these examples won't behave as expected with hosts => "${ES_HOSTS}"
|
|
||
| * `ES_HOSTS="es1.example.com es2.example.com:9201 es3.example.com:9201"` | ||
| * `ES_HOSTS="127.0.0.1:9200 127.0.0.2:9200"` | ||
| * `ES_HOSTS="http://127.0.0.1 http://127.0.0.2"` |
Contributor
There was a problem hiding this comment.
not sure what the back-story is but these aren't working properly.
the first 2 examples will start although I do not think the host fall-over is working (only the first entry is extracted by the client library). for the second half of examples - they simply fail to start the plugin.
alexcams
pushed a commit
to alexcams/logstash-filter-elasticsearch
that referenced
this pull request
Jan 22, 2026
* Refactor: remove unused local variable * Refactor: remove (unused) codec default * Refactor: review/unify error logging format + reviewed event logging to include meta-data details * Deps: move (unused) plain codec to dev dependency * Deps: drop redundant sequel dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve documentation by adding meaningful examples