Skip to content

ci: fix release-please versioning config key - #262

Merged
xiaoyijun merged 1 commit into
v2.xfrom
xiaoyijun-ci-fix-versioning-key-v2x
Jun 11, 2026
Merged

ci: fix release-please versioning config key#262
xiaoyijun merged 1 commit into
v2.xfrom
xiaoyijun-ci-fix-versioning-key-v2x

Conversation

@xiaoyijun

Copy link
Copy Markdown
Collaborator

Summary

Same fix as #261 for the v2 line: the manifest config key is versioning, not versioning-strategy (unknown keys are silently ignored by release-please), so the always-bump-patch guard from #256 was not actually in effect.

Testing

N/A (verified against release-please source)

Checklist

  • .changeset (N/A — this repo uses release-please)
  • unit tests (N/A)
  • integration tests (N/A)
  • necessary KDoc comments (N/A)

🤖 Generated with Claude Code

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the release-please configuration so the intended versioning strategy is actually applied on the v2 maintenance line (previously the key was ignored due to using an unknown config field).

Changes:

  • Replace the incorrect versioning-strategy key with the correct versioning key (always-bump-patch) in the release-please config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xiaoyijun
xiaoyijun merged commit 7aa5e55 into v2.x Jun 11, 2026
4 checks passed
@xiaoyijun
xiaoyijun deleted the xiaoyijun-ci-fix-versioning-key-v2x branch June 11, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants