Net6 #775
Net6 #775
Conversation
|
yes pls NET6 LTS |
src/BaGet.Aliyun/BaGet.Aliyun.csproj
Outdated
| <LangVersion>10.0</LangVersion> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'"> | ||
| <LangVersion>10.0</LangVersion> |
There was a problem hiding this comment.
Isn't the langversion coupled to the framework now anyway, do we really need this?
src/BaGet.Aliyun/BaGet.Aliyun.csproj
Outdated
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.1.1" /> |
There was a problem hiding this comment.
Have you tested this in a docker container? I recall sourcelink being complicated when trying to put it in a docker container. Also do we really need sourcelink for something that is mainly a standalone application?
src/BaGet/appsettings.json
Outdated
| // "Endpoints": { | ||
| // "Http": { | ||
| // "Url": "http://localhost:8080" | ||
| // "Url": "http://*:11050" |
There was a problem hiding this comment.
It's nice with the asterisk, but why port 11050?
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BaGet.Azure", "src\BaGet.Azure\BaGet.Azure.csproj", "{716C970D-9614-4265-AC92-57E8B227B98E}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BaGet.Core.Tests", "tests\BaGet.Core.Tests\BaGet.Core.Tests.csproj", "{89AB1AE2-6CAA-4809-8B74-D78CBE00B049}" |
|
After enabling the tests I get following error: I fixed it by Replacing occourances of |
|
The only way I can imagine this error happening is if there's a datetime of 0001-01-01 and then the offset pushes it below that date. I'm kinda sick today so I won't check now, but if you push it with tests enabled I can checkout your branch tomorrow and see if I can find something causing that. I don't think there should be a datetime of 0001-01-01 anywhere so this might be important. |
|
I just had time to publish the changes again @Regenhardt. They are here |
|
Fixed the last Unit Test in #786 |
4 participants
主版本升级为.NET7
并且升级了绝大部分相关依赖版本
目前为止运行状态良好
如果需要可以自行构建Releases
Addresses #761