Skip to content

Conversation

Shamus03
Copy link

Add a new storage type option that stores package contents in MySql
along with the package metadata.

Though MySql is not the best for storing large file contents, this is an
alternative to storing package contents in the file system, which should be
better for highly-available/distributed use cases.

Shamus03 added 4 commits July 7, 2023 19:31
Add a new storage type option that stores package contents in MySql
along with the package metadata. Though MySql is not the best for
storing large file contents, this is an alternative to storing package
contents in the file system, which should be better for
highly-available/distributed use cases.
@Shamus03
Copy link
Author

More information about our use case. We run BaGet in multiple datacenters pointing to a MySql database. Since BaGet only supports saving package contents to the file system, we use a distributed file system to store those documents. However, distributed file systems are not perfect and sparing you the details, we think it would be better for us to store the package contents in our MySql database along with the package metadata so everything is in one place. I think this will not be an uncommon thought.

return provider.GetRequiredService<FileStorageService>();
}

if (configuration.HasStorageType("mysql"))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this should perhaps be "database" not "mysql". What do you think @loic-sharma?

Comment on lines +11 to +19
migrationBuilder.AlterColumn<DateTime>(
name: "RowVersion",
table: "Packages",
rowVersion: true,
nullable: true,
oldClrType: typeof(DateTime),
oldType: "timestamp(6)",
oldNullable: true)
.Annotation("MySql:ValueGenerationStrategy", MySqlValueGenerationStrategy.ComputedColumn);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tempted to remove this but I see it is in every other migration file. Do you have a preference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant