feat(*): step 5 by aoudiamoncef · Pull Request #14 · loicmathieu/bookmarkit

aoudiamoncef · 2019-10-29T20:37:29Z

No description provided.

feat: solution for step 1 refactor(*): Update Postman collection

feat(*): step 1

feat(*): step 2

feat(*): Add step 5 feat(*): Add step 3 feat: small enhancements refactor(*): Update Postman collection

feat(*): step 3

loicmathieu · 2020-05-25T11:02:09Z

Can you rebase this one onto step-5.
Can you also squash all commits after this ?

aoudiamoncef · 2020-05-25T11:10:46Z

@loicmathieu done

loicmathieu

Please do the requested changes

loicmathieu · 2020-05-25T11:28:20Z

bookmark-service/src/main/java/fr/loicmathieu/bookmarkit/BookmarkResource.java

-        LOGGER.info("Hello {}", greeting);
+        LOGGER.infof("Hello %s", greeting);


If this is working, please don't change it to keep the changes straighforward

loicmathieu · 2020-05-25T11:28:41Z

bookmark-service/src/main/java/fr/loicmathieu/bookmarkit/BookmarkResource.java

-    private static final Logger LOGGER = LoggerFactory.getLogger(BookmarkResource.class);
+    private static final Logger LOGGER = Logger.getLogger(BookmarkResource.class);


If it is working please don't change it to keep the changes straighfroward

loicmathieu · 2020-05-25T11:28:54Z

bookmark-service/pom.xml

+    <!-- test dependencies-->
+    <dependency>
+      <groupId>io.rest-assured</groupId>
+      <artifactId>rest-assured</artifactId>
+      <scope>test</scope>
+    </dependency>


loicmathieu · 2020-05-25T11:29:05Z

bookmark-service/pom.xml

+    <!--/ Step 5 dependencies -->
+    <!-- Step 6 dependencies -->


wrong comment

loicmathieu · 2020-05-25T11:29:08Z

bookmark-service/pom.xml

      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-smallrye-health</artifactId>
    </dependency>
+    <!-- Step 5 dependencies -->


wrong comment

loicmathieu · 2020-05-25T11:29:37Z

bookmark-service/pom.xml

    <maven.compiler.target>1.8</maven.compiler.target>
    <maven.compiler.source>1.8</maven.compiler.source>
-    <quarkus.version>0.26.1</quarkus.version>
+    <quarkus.version>0.28.1</quarkus.version>


I will change the quarkus version in master and rebase all branches later. Can you revert this change ?

loicmathieu · 2020-05-25T11:29:42Z

bookmark-message-consumer/pom.xml

    <maven.compiler.target>1.8</maven.compiler.target>
    <maven.compiler.source>1.8</maven.compiler.source>
-    <quarkus.version>0.22.0</quarkus.version>
+    <quarkus.version>0.28.1</quarkus.version>


I will change the quarkus version in master and rebase all branches later. Can you revert this change ?

loicmathieu · 2020-05-25T11:30:18Z

README.md

 - Modify `BookmarkResource` to read this configuration property and log it at startup:
  - Use `@ConfigProperty` to inject the property inside a `greeting` variable.
-  - Create a `@PostConstruct` method that log it via `log.info("Hello {}", greeting)` using [SLFJ](https://www.slf4j.org/).
+  - Create a `@PostConstruct` method that log it via `LOGGER.infof("Hello %s", greeting)` using [Jboss logging](https://docs.jboss.org/jbosslogging/latest/org/jboss/logging/Logger.html).


See my other comment, please don't do this if it previously works as the LOG usage is froma different step

loicmathieu · 2020-05-25T11:30:41Z

geoip-service/pom.xml

        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
        <surefire-plugin.version>2.22.0</surefire-plugin.version>
-        <quarkus.version>0.26.1</quarkus.version>
+        <quarkus.version>0.28.1</quarkus.version>


I'll change the quarkus version later from master ...

feat(*): Add step 5 feat: small enhancements feat: solution for step 5 refactor(*): Update Postman collection

loicmathieu · 2020-05-26T15:07:43Z

Can you rebase onto step-5 and squash all commits please ?

aoudiamoncef force-pushed the step-5 branch 2 times, most recently from 6217af9 to 002be23 Compare November 12, 2019 21:29

feat: solution for step 1

b89230e

loicmathieu force-pushed the step-5 branch from 893f624 to 179d2c1 Compare May 22, 2020 14:04

feat(*): step 1

64e86f9

feat: solution for step 1 refactor(*): Update Postman collection

aoudiamoncef force-pushed the step-5 branch from 002be23 to d70bcaf Compare May 22, 2020 15:07

Merge pull request loicmathieu#11 from aoudiamoncef/step-1

25a10f0

feat(*): step 1

loicmathieu force-pushed the step-5 branch from 179d2c1 to eab1e33 Compare May 24, 2020 15:32

loicmathieu and others added 18 commits May 24, 2020 17:55

fix: bad merge

b4b0bc5

feat: solution for step 2

117b2fd

feat: solution for step 2

5556829

feat: solution for step 1

03f25ad

feat: solution for step 2

4d99d30

feat(*): step 2

cead24c

Merge pull request loicmathieu#12 from aoudiamoncef/step-2

cc7b402

feat(*): step 2

feat: solution for step 3

102df79

feat: solution for step 2

a74a35f

feat: solution for step 3

fd460bc

feat: solution for step 1

8c659e0

feat: solution for step 2

8c9229a

feat: solution for step 3

88567e7

feat(*): step 3

3001597

feat(*): Add step 5 feat(*): Add step 3 feat: small enhancements refactor(*): Update Postman collection

Merge pull request loicmathieu#13 from aoudiamoncef/step-3

c5cc8cc

feat(*): step 3

feat: solution for step 2

3ca3873

feat: solution for step 3

e629447

feat: solution for step 5

9af6398

loicmathieu force-pushed the step-5 branch from eab1e33 to 156a287 Compare May 25, 2020 11:01

loicmathieu added 3 commits May 25, 2020 13:01

feat: solution for step 1

bbe43c8

feat: solution for step 2

a9afcc9

feat: solution for step 3

1f23dd3

feat: solution for step 5

24ff737

aoudiamoncef force-pushed the step-5 branch from d70bcaf to 4d04412 Compare May 25, 2020 11:10

aoudiamoncef force-pushed the step-5 branch from 4d04412 to c9845ac Compare May 25, 2020 11:25

loicmathieu requested changes May 25, 2020

View reviewed changes

feat(*): step 5

58f5c4b

feat(*): Add step 5 feat: small enhancements feat: solution for step 5 refactor(*): Update Postman collection

aoudiamoncef force-pushed the step-5 branch from c9845ac to 58f5c4b Compare May 25, 2020 12:04

loicmathieu force-pushed the step-5 branch from 156a287 to 8facc94 Compare May 26, 2020 15:03

loicmathieu force-pushed the step-5 branch from 8facc94 to 175a0f3 Compare October 15, 2020 12:35

		LOGGER.info("Hello {}", greeting);
		LOGGER.infof("Hello %s", greeting);

		private static final Logger LOGGER = LoggerFactory.getLogger(BookmarkResource.class);
		private static final Logger LOGGER = Logger.getLogger(BookmarkResource.class);

Conversation

aoudiamoncef commented Oct 29, 2019

Uh oh!

loicmathieu commented May 25, 2020

Uh oh!

aoudiamoncef commented May 25, 2020

Uh oh!

loicmathieu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loicmathieu commented May 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants