Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the generic set.NewSet constructor accept initial values while updating the Go toolchain and CI configuration.
Changes:
- Update
NewSet[T]to accept a variadic list of initial values and populate the underlyingsync.MapviaAdd. - Add tests covering
NewSetinitialization behavior (empty, with values, duplicates, and different types) and refactor internalsync.Map.Rangecallbacks to useany. - Bump the module’s Go version to 1.25 and update the GitHub Actions workflow to use newer action versions and Go 1.25.x.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| set/set.go | Extends NewSet to accept initial values and modernizes Range callback parameter types to any. |
| set/set_test.go | Adds comprehensive tests validating NewSet initialization semantics for ints and strings, including deduplication. |
| go.mod | Updates the declared Go version to 1.25 to align with the updated CI Go toolchain. |
| .github/workflows/push.yml | Refreshes CI configuration to use ubuntu-latest, newer checkout/setup-go actions, and Go 1.25.x. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.