Skip to content

Bump @lokalise/connector-api-contracts from 1.8.0 to 1.29.2 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump @lokalise/connector-api-contracts from 1.8.0 to 1.29.2 #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@fastify/awilix": "^8.2.0",
"@lokalise/api-contracts": "^5.4.0",
"@lokalise/backend-http-client": "^7.2.0",
"@lokalise/connector-api-contracts": "^1.8.0",
"@lokalise/connector-api-contracts": "^1.29.2",
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

pkg='@lokalise/connector-api-contracts'

echo '== npm metadata comparison =='
for v in 1.8.0 1.29.2; do
  echo
  echo "-- ${pkg}@${v} --"
  npm view "${pkg}@${v}" \
    version \
    _npmUser \
    maintainers \
    repository \
    peerDependencies \
    dependencies \
    engines \
    dist.tarball \
    dist.integrity \
    --json
done

echo
echo '== local manifest / lockfile references =='
fd '^(package\.json|package-lock\.json|npm-shrinkwrap\.json|pnpm-lock\.yaml|yarn\.lock)$' -x sh -c '
  file="$1"
  echo
  echo "-- ${file} --"
  rg -n "@lokalise/connector-api-contracts|@lokalise/api-contracts|@lokalise/fastify-api-contracts|@lokalise/node-core|zod" "$file" || true
' sh {}

echo
echo 'Expected result:'
echo '- 1.29.2 does not introduce peer/dependency requirements that exceed the versions pinned in this repo.'
echo '- The lockfile, if present, resolves `@lokalise/connector-api-contracts` to the same 1.29.2 artifact reported by npm.'

Repository: lokalise/ce-connector-template-node

Length of output: 7265

Update root @lokalise/api-contracts to align with @lokalise/connector-api-contracts@1.29.2 dependency.

The bump to @lokalise/connector-api-contracts@1.29.2 introduces a transitive dependency on @lokalise/api-contracts@^6.0.0, but your root package.json still pins @lokalise/api-contracts@^5.4.0. This causes npm to nest the newer version under node_modules/@lokalise/connector-api-contracts/, creating a duplicate in the dependency tree. Peer dependencies (zod, @lokalise/zod-extras, @lokalise/api-common) and lockfile resolution are compatible. The npm publisher change is a security improvement (OIDC trusted publishing). Update the root @lokalise/api-contracts to ^6.0.0 or verify the mixed-version approach is intentional.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 30, Root package.json pins "@lokalise/api-contracts" at
^5.4.0 while "@lokalise/connector-api-contracts" was bumped to ^1.29.2 and
brings a transitive "@lokalise/api-contracts@^6.0.0"; update the root dependency
"@lokalise/api-contracts" to "^6.0.0" (or confirm the mixed-version strategy) so
npm doesn't nest a duplicate under "@lokalise/connector-api-contracts" and to
align versions for "@lokalise/connector-api-contracts" and
"@lokalise/api-contracts".

"@lokalise/fastify-api-contracts": "^4.2.1",
"@lokalise/fastify-extras": "^30.2.1",
"@lokalise/node-core": "^14.7.4",
Expand Down
Loading