Skip to content

Bump @biomejs/biome from 1.9.4 to 2.4.9 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

Bump @biomejs/biome from 1.9.4 to 2.4.9 #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
},
"devDependencies": {
"@amplitude/analytics-types": "^2.10.0",
"@biomejs/biome": "^1.9.4",
"@biomejs/biome": "^2.4.9",
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify Biome v2.4.9 works correctly with existing configuration and codebase.

echo "=== Checking if biome.json exists and is v2-compatible ==="
if [ -f "biome.json" ]; then
  echo "Found biome.json"
  # Check schema version
  cat biome.json | jq -r '."$schema"'
else
  echo "ERROR: biome.json not found"
fi

echo ""
echo "=== Running lint script (dry-run to check for violations) ==="
npm run lint 2>&1 | head -100

echo ""
echo "=== Checking Biome CLI version after update ==="
npx biome --version

Repository: lokalise/fastify-extras

Length of output: 6720

Update suppression comments to Biome v2.4.9 format—lint script currently fails.

The major version upgrade to Biome v2.4.9 introduces stricter validation of suppression comments. The existing codebase contains suppression comments with <explanation> placeholders, which Biome v2.4.9 rejects as invalid. The npm run lint script fails with multiple suppression errors.

Affected files require the following fix:

  • Replace: // biome-ignore lint/<rule>: <explanation>
  • With: // biome-ignore lint: <reason> (where <reason> is a brief justification)

Files requiring updates:

  • lib/errors/errorHandler.ts:18
  • lib/jwt-utils/tokenUtils.ts:29, :32
  • lib/plugins/bull-mq-metrics/queueDiscoverers.ts:56

Ensure npm run lint completes successfully before merging.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 65, Update the Biome suppression comments to the v2.4.9
format by replacing any occurrences of the old pattern "// biome-ignore
lint/<rule>: <explanation>" with the new pattern "// biome-ignore lint:
<reason>" in the specified files: change the suppression in
lib/errors/errorHandler.ts (around the handleError symbol) to use a concise
reason, update both suppressions in lib/jwt-utils/tokenUtils.ts (near
generateToken and verifyToken) to use brief reasons, and adjust the suppression
in lib/plugins/bull-mq-metrics/queueDiscoverers.ts (near discoverQueues)
likewise; ensure each replacement provides a short justification string and then
run npm run lint to verify all suppression errors are resolved before merging.

"@lokalise/backend-http-client": "^10.0.0",
"@opentelemetry/api": "^1.9.0",
"@lokalise/background-jobs-common": "^14.0.2",
Expand Down
Loading