Skip to content

Chore/error utils common tsconfig#538

Merged
CarlosGamero merged 6 commits intomainfrom
chore/error-utils_common-tsconfig
Mar 13, 2025
Merged

Chore/error utils common tsconfig#538
CarlosGamero merged 6 commits intomainfrom
chore/error-utils_common-tsconfig

Conversation

@CarlosGamero
Copy link
Copy Markdown
Collaborator

@CarlosGamero CarlosGamero commented Mar 12, 2025

Changes

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@CarlosGamero CarlosGamero self-assigned this Mar 12, 2025
@CarlosGamero
Copy link
Copy Markdown
Collaborator Author

CarlosGamero commented Mar 12, 2025

Prisma utils depends on error utils, so we need to migrate prisma lib before continuing with this

let context = {}
const event = {
addMetadata: (key, obj) => {
addMetadata: (key: any, obj: any) => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use unknown instead?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was not important as they are just tests, but you are right!

@CarlosGamero CarlosGamero marked this pull request as ready for review March 13, 2025 16:09
@CarlosGamero CarlosGamero requested review from a team and dariacm as code owners March 13, 2025 16:09
@CarlosGamero CarlosGamero merged commit a0e9bbf into main Mar 13, 2025
5 checks passed
@CarlosGamero CarlosGamero deleted the chore/error-utils_common-tsconfig branch March 13, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants