Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 78 additions & 13 deletions packages/app/drizzle-utils/src/drizzleFullBulkUpdate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,43 @@ describe('drizzleFullBulkUpdate', () => {
})

const enumSchema = 'enum_schema'
const enumName = 'statuss'
const statusEnum = pgSchema(enumSchema).enum(enumName, ['active', 'inactive'])

const enumTableName = 'test_enum'
const enumTable = pgTable(enumTableName, {
const standardStatusEnumName = 'standard_status'
const standardStatusEnum = pgSchema(enumSchema).enum(standardStatusEnumName, [
'active',
'inactive',
])

const standardEnumTableName = 'test_standard_enum'
const standardEnumTable = pgTable(standardEnumTableName, {
id: smallint(),
status: standardStatusEnum(),
})

const ObjectStatusEnum = { ACTIVE: 'active', INACTIVE: 'inactive' } as const
const objectStatusEnumName = 'object_status'
const objectStatusDbEnum = pgSchema(enumSchema).enum(objectStatusEnumName, ObjectStatusEnum)

const objectEnumTableName = 'test_object_enum'
const objectEnumTable = pgTable(objectEnumTableName, {
id: smallint(),
status: statusEnum(),
status: objectStatusDbEnum(),
})

beforeAll(async () => {
await db.execute(
`DROP TABLE IF EXISTS ${surrogateTableName}, ${surrogateJsonTableName}, ${compositeTableName}, ${enumTableName}`,
`DROP TABLE IF EXISTS ${surrogateTableName}, ${surrogateJsonTableName}, ${compositeTableName}, ${standardEnumTableName}, ${objectEnumTableName}`,
)
await db.execute(`DROP TYPE IF EXISTS ${enumSchema}.${enumName}`)
await db.execute(`DROP TYPE IF EXISTS ${enumSchema}.${standardStatusEnumName}`)
await db.execute(`DROP TYPE IF EXISTS ${enumSchema}.${objectStatusEnumName}`)

await db.execute(`CREATE SCHEMA IF NOT EXISTS ${enumSchema}`)
await db.execute(`CREATE TYPE ${enumSchema}.${enumName} AS ENUM ('active', 'inactive')`)
await db.execute(
`CREATE TYPE ${enumSchema}.${standardStatusEnumName} AS ENUM ('active', 'inactive')`,
)
await db.execute(
`CREATE TYPE ${enumSchema}.${objectStatusEnumName} AS ENUM ('active', 'inactive')`,
)

await Promise.all([
db.execute(
Expand All @@ -57,7 +77,12 @@ describe('drizzleFullBulkUpdate', () => {
db.execute(
`CREATE TABLE ${compositeTableName} (id1 smallint, id2 smallint, col1 smallint, col2 smallint)`,
),
db.execute(`CREATE TABLE ${enumTableName} (id smallint, status ${enumSchema}.${enumName})`),
db.execute(
`CREATE TABLE ${standardEnumTableName} (id smallint, status ${enumSchema}.${standardStatusEnumName})`,
),
db.execute(
`CREATE TABLE ${objectEnumTableName} (id smallint, status ${enumSchema}.${objectStatusEnumName})`,
),
])
})

Expand All @@ -66,7 +91,8 @@ describe('drizzleFullBulkUpdate', () => {
db.delete(surrogateTable),
db.delete(surrogateJsonTable),
db.delete(compositeTable),
db.delete(enumTable),
db.delete(standardEnumTable),
db.delete(objectEnumTable),
])
})

Expand Down Expand Up @@ -250,15 +276,35 @@ describe('drizzleFullBulkUpdate', () => {

it('handles enum columns correctly', async () => {
await db.execute(
`INSERT INTO ${enumTableName} (id, status) VALUES (1, 'active'), (2, 'active')`,
`INSERT INTO ${standardEnumTableName} (id, status) VALUES (1, 'active'), (2, 'active')`,
)

await drizzleFullBulkUpdate(db, enumTable, [
await drizzleFullBulkUpdate(db, standardEnumTable, [
{ where: { id: 1 }, data: { status: 'inactive' } },
{ where: { id: 2 }, data: { status: 'inactive' } },
])

const updatedData = await db.execute(`SELECT * FROM ${enumTableName}`)
const updatedData = await db.execute(`SELECT * FROM ${standardEnumTableName}`)

expect(updatedData).toEqual(
expect.arrayContaining([
{ id: 1, status: 'inactive' },
{ id: 2, status: 'inactive' },
]),
)
})

it('handles object enum columns correctly', async () => {
await db.execute(
`INSERT INTO ${objectEnumTableName} (id, status) VALUES (1, 'active'), (2, 'active')`,
)

await drizzleFullBulkUpdate(db, objectEnumTable, [
{ where: { id: 1 }, data: { status: ObjectStatusEnum.INACTIVE } },
{ where: { id: 2 }, data: { status: ObjectStatusEnum.INACTIVE } },
])

const updatedData = await db.execute(`SELECT * FROM ${objectEnumTableName}`)

expect(updatedData).toEqual(
expect.arrayContaining([
Expand All @@ -267,4 +313,23 @@ describe('drizzleFullBulkUpdate', () => {
]),
)
})

it('handles object enum in where condition correctly', async () => {
await db.execute(
`INSERT INTO ${objectEnumTableName} (id, status) VALUES (1, 'active'), (2, 'inactive')`,
)

await drizzleFullBulkUpdate(db, objectEnumTable, [
{ where: { status: ObjectStatusEnum.ACTIVE }, data: { id: 10 } },
])

const updatedData = await db.execute(`SELECT * FROM ${objectEnumTableName}`)

expect(updatedData).toEqual(
expect.arrayContaining([
{ id: 10, status: 'active' },
{ id: 2, status: 'inactive' },
]),
)
})
})
8 changes: 5 additions & 3 deletions packages/app/drizzle-utils/src/drizzleFullBulkUpdate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { getTableColumns, is, sql } from 'drizzle-orm'
import {
getTableConfig,
PgEnumColumn,
PgEnumObjectColumn,
type PgTable,
type PgUpdateSetSource,
} from 'drizzle-orm/pg-core'
Expand All @@ -28,9 +29,10 @@ const getColumns = (table: PgTable, columnNames: string[]): Column[] => {
throw new Error(`Column "${columnName}" could not be mapped to table`)
}

const type = is(tableColumn, PgEnumColumn)
? `"${tableColumn.enum.schema ?? 'public'}".${tableColumn.enum.enumName}`
: tableColumn.getSQLType()
const type =
is(tableColumn, PgEnumColumn) || is(tableColumn, PgEnumObjectColumn)
? `"${tableColumn.enum.schema ?? 'public'}".${tableColumn.enum.enumName}`
: tableColumn.getSQLType()

return { key: columnName, name: tableColumn.name, type }
})
Expand Down
Loading