Skip to content

Bump wretch from 2.11.1 to 3.0.7 #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

Bump wretch from 2.11.1 to 3.0.7 #886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/universal-testing-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"rimraf": "^6.0.1",
"typescript": "5.9.3",
"vitest": "^4.0.15",
"wretch": "^2.11.0",
"wretch": "^3.0.7",
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "# Node/toolchain declarations"
fd -HI '(^package\.json$|^\.nvmrc$|^\.node-version$|^\.tool-versions$)' | while read -r f; do
  echo "## $f"
  if [[ "$f" == *.json ]]; then
    rg -nC2 '"engines"|"packageManager"|"volta"|"node"' "$f" || true
  else
    sed -n '1,20p' "$f"
  fi
  echo
done

echo "# CI node versions"
if [[ -d .github/workflows ]]; then
  fd -HI '\.ya?ml$' .github/workflows -x rg -nC2 'setup-node|node-version' {}
fi

echo "# Wretch imports and v2-only APIs"
rg -nC2 --glob '!**/dist/**' --glob '!**/node_modules/**' \
  'from ["'"'"']wretch["'"'"']|require\(["'"'"']wretch["'"'"']\)|\.polyfills\s*\(|wretch\.polyfills\s*\(|wretch\.options\s*\(|\.errorType\s*\(|wretch\.errorType\s*\('

Repository: lokalise/shared-ts-libs

Length of output: 2570

Add engines.node constraint to match wretch@^3's Node.js 22+ requirement.

The monorepo's CI tests on Node 22.x and 24.x, and no v2-only wretch APIs remain in use. However, universal-testing-utils (and the root package.json) do not declare an explicit engines.node floor. This allows installation on Node <22 locally, which would fail at runtime with wretch@^3. Add "engines": { "node": ">=22.0.0" } to this package's package.json (or rely on a root-level engines declaration if established repository-wide).

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/app/universal-testing-utils/package.json` at line 64, Add an
explicit Node engine floor to this package's package.json to prevent installing
wretch@^3 on unsupported Node versions: in
packages/app/universal-testing-utils/package.json add an "engines" field with
"node": ">=22.0.0" (or ensure the repo root package.json already declares the
same and remove duplication), so the package's dependency on "wretch": "^3.0.7"
is constrained to Node 22+. Update the package.json top-level object (near the
existing dependencies block) to include the "engines" entry.

"zod": "^4.3.6"
},
"dependencies": {}
Expand Down
Loading