Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: lokalise/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
# Conflicts: # packages/app/api-contracts/src/sse/dualModeContracts.ts # packages/app/api-contracts/src/sse/sseContractBuilders.ts # packages/app/api-contracts/src/sse/sseContracts.ts
| * Provides a common base for metadata and OpenAPI documentation fields | ||
| * that are independent of schema types. | ||
| */ | ||
| export type BaseContractDefinition = { |
There was a problem hiding this comment.
Reducing duplication but adding a base type
| metadata: ApiContract['metadata'], | ||
| ) => Pick< | ||
| RouteType, | ||
| RouteOptions, |
There was a problem hiding this comment.
By using the generic Fastify RouteOptions, the type remains compatible with Opinionated Machine and likely with other libraries as well. If we use the custom RouteType, it introduces type issues.
For this case, both types are equivalent.
1 participant
Changes
Checklist
major,minor,patchorskip-releaseAI Assistance Tracking
We're running a metric to understand where AI assists our engineering work. Please select exactly one of the options below:
Mark "Yes" if AI helped in any part of this work, for example: generating code, refactoring, debugging support,
explaining something, reviewing an idea, or suggesting an approach.