feat: extract event routing types into @lokalise/aws-event-routing-types#897
feat: extract event routing types into @lokalise/aws-event-routing-types#897laurismikals wants to merge 1 commit intomainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: lokalise/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR introduces a new TypeScript types-only package, Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Create new zero-dependency package @lokalise/aws-event-routing-types containing EventRoutingConfig, QueueConfig, TopicConfig, CommandConfig, and AwsTagsParams types. Update @lokalise/aws-config to re-export these types from the new package. Wire new package into CI and release workflows. Made-with: Cursor
05a2580 to
a6320e9
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/app/aws-event-routing-types/src/awsTagsParams.ts (1)
1-1: Consider exportingAppEnvfor consumer convenience.The
AppEnvtype is used internally for theappEnvfield but not exported. Consumers who want to type-check environment values independently would benefit from having this type available.Suggested change
-type AppEnv = 'production' | 'development' | 'staging' +export type AppEnv = 'production' | 'development' | 'staging'If exported, also add it to
index.ts:export type { AppEnv, AwsTagsParams } from './awsTagsParams.ts'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/app/aws-event-routing-types/src/awsTagsParams.ts` at line 1, Export the AppEnv type so consumers can reuse it: add an export to the AppEnv declaration (export type AppEnv = 'production' | 'development' | 'staging') and ensure the AwsTagsParams type remains exported; then update your public exports (e.g., in index.ts) to re-export AppEnv alongside AwsTagsParams (export type { AppEnv, AwsTagsParams } from './awsTagsParams') so both types are available to consumers.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/app/aws-event-routing-types/src/awsTagsParams.ts`:
- Line 1: Export the AppEnv type so consumers can reuse it: add an export to the
AppEnv declaration (export type AppEnv = 'production' | 'development' |
'staging') and ensure the AwsTagsParams type remains exported; then update your
public exports (e.g., in index.ts) to re-export AppEnv alongside AwsTagsParams
(export type { AppEnv, AwsTagsParams } from './awsTagsParams') so both types are
available to consumers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: lokalise/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8bb14055-38d2-4ad7-812d-fb2c067ad4d9
📒 Files selected for processing (13)
.github/workflows/ci.yml.github/workflows/release.ymlpackages/app/aws-config/package.jsonpackages/app/aws-config/src/event-routing/eventRoutingConfig.tspackages/app/aws-config/src/tags/common.tspackages/app/aws-event-routing-types/README.mdpackages/app/aws-event-routing-types/package.jsonpackages/app/aws-event-routing-types/src/awsTagsParams.tspackages/app/aws-event-routing-types/src/eventRoutingConfig.tspackages/app/aws-event-routing-types/src/index.tspackages/app/aws-event-routing-types/tsconfig.build.jsonpackages/app/aws-event-routing-types/tsconfig.jsonpackages/app/aws-event-routing-types/vitest.config.ts
Create new zero-dependency package @lokalise/aws-event-routing-types containing EventRoutingConfig, QueueConfig, TopicConfig, CommandConfig, and AwsTagsParams types. Update @lokalise/aws-config to re-export these types from the new package. Wire new package into CI and release workflows.
Made-with: Cursor
Changes
Please describe
Checklist
major,minor,patchorskip-releaseAI Assistance Tracking
We're running a metric to understand where AI assists our engineering work. Please select exactly one of the options below:
Mark "Yes" if AI helped in any part of this work, for example: generating code, refactoring, debugging support,
explaining something, reviewing an idea, or suggesting an approach.