Bump the opentelemetry group across 1 directory with 9 updates#903
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
Bump the opentelemetry group across 1 directory with 9 updates#903dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
dependabot
bot
requested review from
a team,
CarlosGamero,
dariacm and
kibertoad
as code owners
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: lokalise/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request updates OpenTelemetry-related dependencies across two package configuration files. In Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/app/context-fastify-plugins/package.json`:
- Around line 42-45: The code still constructs a Resource via the removed v1 API
(new Resource(...)) in prismaOtelTracingPlugin (look for the Resource usage in
packages/app/context-fastify-plugins/src/plugins/opentelemetry/prismaOtelTracingPlugin.ts);
replace that with the v2 API by importing and using resourceFromAttributes(...)
(and adjust imports to pull resourceFromAttributes from `@opentelemetry/resources`
instead of Resource), passing the same attributes previously given to the
Resource constructor so the Resource is created via resourceFromAttributes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: lokalise/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4ff32487-4b58-457a-83fe-c747697fae7c
📒 Files selected for processing (2)
packages/app/context-fastify-plugins/package.jsonpackages/app/opentelemetry-fastify-bootstrap/package.json
Comment on lines
+42
to
+45
| "@opentelemetry/resources": "2.6.1", | ||
| "@opentelemetry/sdk-trace-base": "2.6.1", | ||
| "@opentelemetry/sdk-trace-node": "2.6.1", | ||
| "@opentelemetry/semantic-conventions": "1.40.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify potentially incompatible v1-style APIs still present with v2 deps.
rg -n -C3 'new\s+Resource\s*\(' --type=ts packages/app/context-fastify-plugins/src/plugins/opentelemetry/prismaOtelTracingPlugin.ts
rg -n -C3 'SEMRESATTRS_SERVICE_NAME' --type=ts packages/app/context-fastify-plugins/src/plugins/opentelemetry/prismaOtelTracingPlugin.tsRepository: lokalise/shared-ts-libs
Length of output: 990
🌐 Web query:
In @opentelemetry/resources2.6.1, what is the recommended replacement fornew Resource({...})? Please provide the official migration/docs link.
💡 Result:
In @opentelemetry/resources 2.6.1, replace:
new Resource({ ... })→resourceFromAttributes({ ... })[1]
Official migration/doc links:
- Migration guide (“
@opentelemetry/resourcesAPI changes”):
https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/upgrade-to-2.x.md#opentelemetryresources-api-changes[1] - API docs for
resourceFromAttributes:
https://open-telemetry.github.io/opentelemetry-js/functions/_opentelemetry_resources.resourceFromAttributes.html[2]
Example
import { resourceFromAttributes } from '@opentelemetry/resources';
const resource = resourceFromAttributes({ 'service.name': 'my-service' });
``` [1][2]
---
</details>
**`@opentelemetry/resources` v2.6.1 requires migration from v1-style API.**
Line 42 upgrades `@opentelemetry/resources` to `2.6.1`, but `packages/app/context-fastify-plugins/src/plugins/opentelemetry/prismaOtelTracingPlugin.ts:23` still uses `new Resource(...)`. In v2.x, this constructor has been removed; migrate to `resourceFromAttributes()` as documented in the [official upgrade guide](https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/upgrade-to-2.x.md#opentelemetryresources-api-changes).
<details>
<summary>Required fix</summary>
```diff
- import { Resource } from '@opentelemetry/resources'
+ import { resourceFromAttributes } from '@opentelemetry/resources'
import { SEMRESATTRS_SERVICE_NAME } from '@opentelemetry/semantic-conventions'
...
- resource: new Resource({
+ resource: resourceFromAttributes({
[SEMRESATTRS_SERVICE_NAME]: opts.serviceName,
}),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/app/context-fastify-plugins/package.json` around lines 42 - 45, The
code still constructs a Resource via the removed v1 API (new Resource(...)) in
prismaOtelTracingPlugin (look for the Resource usage in
packages/app/context-fastify-plugins/src/plugins/opentelemetry/prismaOtelTracingPlugin.ts);
replace that with the v2 API by importing and using resourceFromAttributes(...)
(and adjust imports to pull resourceFromAttributes from `@opentelemetry/resources`
instead of Resource), passing the same attributes previously given to the
Resource constructor so the Resource is created via resourceFromAttributes.
3db6bc3 to
916ddf2
Compare
Bumps the opentelemetry group with 9 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@opentelemetry/api](https://github.com/open-telemetry/opentelemetry-js) | `1.9.0` | `1.9.1` | | [@opentelemetry/exporter-trace-otlp-grpc](https://github.com/open-telemetry/opentelemetry-js) | `0.57.2` | `0.214.0` | | [@opentelemetry/instrumentation](https://github.com/open-telemetry/opentelemetry-js) | `0.57.2` | `0.214.0` | | [@opentelemetry/resources](https://github.com/open-telemetry/opentelemetry-js) | `1.30.1` | `2.6.1` | | [@opentelemetry/sdk-trace-base](https://github.com/open-telemetry/opentelemetry-js) | `1.30.1` | `2.6.1` | | [@opentelemetry/sdk-trace-node](https://github.com/open-telemetry/opentelemetry-js) | `1.30.1` | `2.6.1` | | [@opentelemetry/semantic-conventions](https://github.com/open-telemetry/opentelemetry-js) | `1.30.0` | `1.40.0` | | [@opentelemetry/auto-instrumentations-node](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/HEAD/packages/auto-instrumentations-node) | `0.68.0` | `0.72.0` | | [@opentelemetry/sdk-node](https://github.com/open-telemetry/opentelemetry-js) | `0.210.0` | `0.214.0` | Updates `@opentelemetry/api` from 1.9.0 to 1.9.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.9.0...v1.9.1) Updates `@opentelemetry/exporter-trace-otlp-grpc` from 0.57.2 to 0.214.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.57.2...experimental/v0.214.0) Updates `@opentelemetry/instrumentation` from 0.57.2 to 0.214.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.57.2...experimental/v0.214.0) Updates `@opentelemetry/resources` from 1.30.1 to 2.6.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.30.1...v2.6.1) Updates `@opentelemetry/sdk-trace-base` from 1.30.1 to 2.6.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.30.1...v2.6.1) Updates `@opentelemetry/sdk-trace-node` from 1.30.1 to 2.6.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.30.1...v2.6.1) Updates `@opentelemetry/semantic-conventions` from 1.30.0 to 1.40.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.30.0...semconv/v1.40.0) Updates `@opentelemetry/auto-instrumentations-node` from 0.68.0 to 0.72.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/packages/auto-instrumentations-node/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-js-contrib/commits/auto-instrumentations-node-v0.72.0/packages/auto-instrumentations-node) Updates `@opentelemetry/sdk-node` from 0.210.0 to 0.214.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.210.0...experimental/v0.214.0) --- updated-dependencies: - dependency-name: "@opentelemetry/api" dependency-version: 1.9.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: opentelemetry - dependency-name: "@opentelemetry/exporter-trace-otlp-grpc" dependency-version: 0.214.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: opentelemetry - dependency-name: "@opentelemetry/instrumentation" dependency-version: 0.214.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: opentelemetry - dependency-name: "@opentelemetry/resources" dependency-version: 2.6.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: opentelemetry - dependency-name: "@opentelemetry/sdk-trace-base" dependency-version: 2.6.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: opentelemetry - dependency-name: "@opentelemetry/sdk-trace-node" dependency-version: 2.6.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: opentelemetry - dependency-name: "@opentelemetry/semantic-conventions" dependency-version: 1.40.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: opentelemetry - dependency-name: "@opentelemetry/auto-instrumentations-node" dependency-version: 0.72.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: opentelemetry - dependency-name: "@opentelemetry/sdk-node" dependency-version: 0.214.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: opentelemetry ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/opentelemetry-a81023a17a
branch
from
916ddf2 to
26b4639
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the opentelemetry group with 9 updates in the / directory:
1.9.01.9.10.57.20.214.00.57.20.214.01.30.12.6.11.30.12.6.11.30.12.6.11.30.01.40.00.68.00.72.00.210.00.214.0Updates
@opentelemetry/apifrom 1.9.0 to 1.9.1Release notes
Sourced from
@opentelemetry/api's releases.Changelog
Sourced from
@opentelemetry/api's changelog.Commits
279458eRelease 1.9.1 / 0.35.1 (#3573)4978743fix(http): remove outgoing headers normalization (#3557)d1f9594chore(deps): update dependency rimraf to v4 (#3532)e0abcc0fix: remove JSON syntax error and regenerate tsconfig files (#3566)a90c558fix(sdk-node): register instrumentations early (#3502)5b070b8fix: include TraceState in trace exports (#3569)dcb09b7chore(deps): update dependency gh-pages to v5 (#3571)3bc93a9feat: exponential histogram - part 1 - mapping functions (#3504)3670071fix: avoid grpc types dependency (#3551)b5ef0e4chore: fix proto generation (#3567)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@opentelemetry/apisince your current version.Updates
@opentelemetry/exporter-trace-otlp-grpcfrom 0.57.2 to 0.214.0Release notes
Sourced from
@opentelemetry/exporter-trace-otlp-grpc's releases.... (truncated)
Commits
7e74509chore: prepare next release (#6510)c846919fix(instrumentation-fetch): do not modify the returned type of fetch (#6521)99fb3fbfix(api): re-introduce fallback chain for global utils (#6523)b842717test(bundlers): add node webpack tests, expand edge coverage, assert known pr...b5a6b12fix(opentelemetry-sdk-node): add missing@opentelemetry/otlp-exporter-basede...dc93ed4perf(sdk-trace-base): optimizeSpan.{addEvent,addLink}performance (#6516)e9831e7perf(sdk-trace-base): avoid Object.entries in Span.setAttributes (#6514)d56af69chore(deps): lock file maintenance (#6517)f3a10abchore(deps): update github/codeql-action digest to 3869755 (#6513)2f73776chore(deps): update github/codeql-action digest to c6f9311 (#6511)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@opentelemetry/exporter-trace-otlp-grpcsince your current version.Updates
@opentelemetry/instrumentationfrom 0.57.2 to 0.214.0Release notes
Sourced from
@opentelemetry/instrumentation's releases.... (truncated)
Commits
7e74509chore: prepare next release (#6510)c846919fix(instrumentation-fetch): do not modify the returned type of fetch (#6521)99fb3fbfix(api): re-introduce fallback chain for global utils (#6523)b842717test(bundlers): add node webpack tests, expand edge coverage, assert known pr...b5a6b12fix(opentelemetry-sdk-node): add missing@opentelemetry/otlp-exporter-basede...dc93ed4perf(sdk-trace-base): optimizeSpan.{addEvent,addLink}performance (#6516)e9831e7perf(sdk-trace-base): avoid Object.entries in Span.setAttributes (#6514)d56af69chore(deps): lock file maintenance (#6517)f3a10abchore(deps): update github/codeql-action digest to 3869755 (#6513)2f73776chore(deps): update github/codeql-action digest to c6f9311 (#6511)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@opentelemetry/instrumentationsince your current version.Updates
@opentelemetry/resourcesfrom 1.30.1 to 2.6.1Release notes
Sourced from
@opentelemetry/resources's releases.... (truncated)
Changelog
Sourced from
@opentelemetry/resources's changelog.... (truncated)
Commits
7e74509chore: prepare next release (#6510)c846919fix(instrumentation-fetch): do not modify the returned type of fetch (#6521)99fb3fbfix(api): re-introduce fallback chain for global utils (#6523)b842717test(bundlers): add node webpack tests, expand edge coverage, assert known pr...b5a6b12fix(opentelemetry-sdk-node): add missing@opentelemetry/otlp-exporter-basede...dc93ed4perf(sdk-trace-base): optimizeSpan.{addEvent,addLink}performance (#6516)e9831e7perf(sdk-trace-base): avoid Object.entries in Span.setAttributes (#6514)d56af69chore(deps): lock file maintenance (#6517)f3a10abchore(deps): update github/codeql-action digest to 3869755 (#6513)2f73776chore(deps): update github/codeql-action digest to c6f9311 (#6511)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@opentelemetry/resourcessince your current version.Updates
@opentelemetry/sdk-trace-basefrom 1.30.1 to 2.6.1Release notes
Sourced from
@opentelemetry/sdk-trace-base's releases.... (truncated)
Changelog
Sourced from
@opentelemetry/sdk-trace-base's changelog.... (truncated)
Commits
7e74509chore: prepare next release (#6510)c846919fix(instrumentation-fetch): do not modify the returned type of fetch (#6521)99fb3fbfix(api): re-introduce fallback chain for global utils (#6523)b842717test(bundlers): add node webpack tests, expand edge coverage, assert known pr...b5a6b12fix(opentelemetry-sdk-node): add missing@opentelemetry/otlp-exporter-basede...dc93ed4perf(sdk-trace-base): optimizeSpan.{addEvent,addLink}performance (#6516)e9831e7perf(sdk-trace-base): avoid Object.entries in Span.setAttributes (#6514)d56af69chore(deps): lock file maintenance (#6517)f3a10abchore(deps): update github/codeql-action digest to 3869755 (#6513)2f73776chore(deps): update github/codeql-action digest to c6f9311 (#6511)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@opentelemetry/sdk-trace-basesince your current version.Updates
@opentelemetry/sdk-trace-nodefrom 1.30.1 to 2.6.1Release notes
Sourced from
@opentelemetry/sdk-trace-node's releases.... (truncated)
Changelog
Sourced from
@opentelemetry/sdk-trace-node's changelog.