Bump typescript from 5.9.3 to 6.0.2 in the typescript group across 1 directory#904
Bump typescript from 5.9.3 to 6.0.2 in the typescript group across 1 directory#904dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: lokalise/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request updates the TypeScript development dependency across 26 package.json files in the monorepo from version 5.9.3 to version 6.0.2. The update is applied uniformly to packages within Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
packages/app/zod-extras/package.json (1)
52-52: Consider aligning TypeScript version pinning strategy across workspaces.Line 52 uses
^6.0.2, while several sibling packages pin exact6.0.2. Standardizing one policy reduces toolchain drift in monorepos.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/app/zod-extras/package.json` at line 52, This package.json currently pins TypeScript with a caret ("typescript": "^6.0.2") which differs from sibling packages that use an exact pin; update the dependency entry to match the monorepo policy by changing "typescript": "^6.0.2" to "typescript": "6.0.2" (or vice‑versa if your workspace standard is caret) and then run the workspace package manager sync/install so lockfiles and hoisted deps reflect the standardized pin; reference the "typescript" dependency in this package.json to locate the change.packages/app/backend-http-client/package.json (1)
58-58: Recommend consistent TypeScript pinning policy in monorepo packages.Line 58 uses a caret range (
^6.0.2) while many related packages use exact6.0.2. Aligning this helps keep compiler behavior predictable across workspaces.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/app/backend-http-client/package.json` at line 58, The TypeScript dependency in this package.json is using a caret range ("typescript": "^6.0.2") while the monorepo standard is pinning to an exact version; update the dependency string to "typescript": "6.0.2" in packages/app/backend-http-client/package.json to match other packages and then reinstall/update the workspace lockfile so all workspaces use the same exact TypeScript version.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/app/context-fastify-plugins/package.json`:
- Line 66: Update the TypeScript dependency in package.json to match the
monorepo's pinned-version policy by replacing the caret-range entry
"typescript": "^6.0.2" with the exact pinned version "typescript": "6.0.2";
locate the dependency in packages/app/context-fastify-plugins/package.json and
ensure the change aligns with other packages' entries.
In `@packages/app/odata-mapper/package.json`:
- Line 46: The TypeScript dependency in package.json is using a caret range
("^6.0.2") causing inconsistency with the rest of the monorepo which pins
"6.0.2"; update the "typescript" entry in the packages/app/odata-mapper
package.json from "^6.0.2" to "6.0.2" so it matches the other packages (ensure
the "typescript" key is the one you change), then reinstall/lock dependencies so
the monorepo uses the pinned version consistently.
---
Nitpick comments:
In `@packages/app/backend-http-client/package.json`:
- Line 58: The TypeScript dependency in this package.json is using a caret range
("typescript": "^6.0.2") while the monorepo standard is pinning to an exact
version; update the dependency string to "typescript": "6.0.2" in
packages/app/backend-http-client/package.json to match other packages and then
reinstall/update the workspace lockfile so all workspaces use the same exact
TypeScript version.
In `@packages/app/zod-extras/package.json`:
- Line 52: This package.json currently pins TypeScript with a caret
("typescript": "^6.0.2") which differs from sibling packages that use an exact
pin; update the dependency entry to match the monorepo policy by changing
"typescript": "^6.0.2" to "typescript": "6.0.2" (or vice‑versa if your workspace
standard is caret) and then run the workspace package manager sync/install so
lockfiles and hoisted deps reflect the standardized pin; reference the
"typescript" dependency in this package.json to locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: lokalise/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 78aa99be-6ecc-4c52-b721-6b388a3e7808
📒 Files selected for processing (28)
packages/app/api-common/package.jsonpackages/app/api-contracts/package.jsonpackages/app/auth/package.jsonpackages/app/aws-config/package.jsonpackages/app/backend-http-client/package.jsonpackages/app/background-jobs-common/package.jsonpackages/app/context-fastify-plugins/package.jsonpackages/app/datadog-fastify-bootstrap/package.jsonpackages/app/drizzle-utils/package.jsonpackages/app/error-utils/package.jsonpackages/app/fastify-api-contracts/package.jsonpackages/app/fastify-bullboard-plugin/package.jsonpackages/app/frontend-http-client/package.jsonpackages/app/healthcheck-utils/package.jsonpackages/app/id-utils/package.jsonpackages/app/metrics-utils/package.jsonpackages/app/non-translatable-markup/package.jsonpackages/app/odata-mapper/package.jsonpackages/app/opentelemetry-fastify-bootstrap/package.jsonpackages/app/polling/package.jsonpackages/app/prisma-utils/package.jsonpackages/app/script-utils/package.jsonpackages/app/supported-languages/package.jsonpackages/app/universal-testing-utils/package.jsonpackages/app/universal-ts-utils/package.jsonpackages/app/websockets-common/package.jsonpackages/app/zod-extras/package.jsonpackages/dev/package-vite-config/package.json
| "pino-pretty": "^13.0.0", | ||
| "rimraf": "^6.0.1", | ||
| "typescript": "^5.9.3", | ||
| "typescript": "^6.0.2", |
There was a problem hiding this comment.
Inconsistent TypeScript version format across monorepo.
This package uses "^6.0.2" while most other packages in this PR use pinned "6.0.2". For consistency and to avoid version drift across the monorepo, align with the pinned version strategy.
📌 Standardize to pinned version
- "typescript": "^6.0.2",
+ "typescript": "6.0.2",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "typescript": "^6.0.2", | |
| "typescript": "6.0.2", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/app/context-fastify-plugins/package.json` at line 66, Update the
TypeScript dependency in package.json to match the monorepo's pinned-version
policy by replacing the caret-range entry "typescript": "^6.0.2" with the exact
pinned version "typescript": "6.0.2"; locate the dependency in
packages/app/context-fastify-plugins/package.json and ensure the change aligns
with other packages' entries.
| "@vitest/coverage-v8": "^4.0.18", | ||
| "rimraf": "^6.1.2", | ||
| "typescript": "^5.9.3", | ||
| "typescript": "^6.0.2", |
There was a problem hiding this comment.
Inconsistent TypeScript version format across monorepo.
This package uses "^6.0.2" (caret range) while most other packages in this PR use pinned "6.0.2". This inconsistency can lead to different TypeScript versions being installed across packages during development, potentially causing subtle type-checking or compilation differences.
📌 Standardize to pinned version
- "typescript": "^6.0.2",
+ "typescript": "6.0.2",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "typescript": "^6.0.2", | |
| "typescript": "6.0.2", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/app/odata-mapper/package.json` at line 46, The TypeScript dependency
in package.json is using a caret range ("^6.0.2") causing inconsistency with the
rest of the monorepo which pins "6.0.2"; update the "typescript" entry in the
packages/app/odata-mapper package.json from "^6.0.2" to "6.0.2" so it matches
the other packages (ensure the "typescript" key is the one you change), then
reinstall/lock dependencies so the monorepo uses the pinned version
consistently.
79f7ca2 to
d9a877f
Compare
Bumps the typescript group with 1 update: [typescript](https://github.com/microsoft/TypeScript). Updates `typescript` from 5.9.3 to 6.0.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v6.0.2) --- updated-dependencies: - dependency-name: typescript dependency-version: 6.0.2 dependency-type: direct:development update-type: version-update:semver-major dependency-group: typescript ... Signed-off-by: dependabot[bot] <support@github.com>
d9a877f to
5d67b30
Compare
Bumps the typescript group with 1 update in the / directory: typescript.
Updates
typescriptfrom 5.9.3 to 6.0.2Release notes
Sourced from typescript's releases.
Commits
607a22aBump version to 6.0.2 and LKG9e72ab7🤖 Pick PR #63239 (Fix missing lib files in reused pro...) into release-6.0 (#...35ff23d🤖 Pick PR #63163 (Port anyFunctionType subtype fix an...) into release-6.0 (#...e175b69Bump version to 6.0.1-rc and LKGaf4caacUpdate LKG8efd7e8Merge remote-tracking branch 'origin/main' into release-6.0206ed1aDeprecate assert in import() (#63172)e688ac8Update dependencies (#63156)29b300dBump the github-actions group across 1 directory with 2 updates (#63205)0c2c7a3DOM update (#63183)