Update lightbox to have autorotation and configurable options.#358
Open
michaeldewolf85 wants to merge 11 commits intolokesh:masterfrom
Open
Update lightbox to have autorotation and configurable options.#358michaeldewolf85 wants to merge 11 commits intolokesh:masterfrom
michaeldewolf85 wants to merge 11 commits intolokesh:masterfrom
Conversation
added 11 commits
December 8, 2014 17:09
de83cee to
c1c0f87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to be able to modify the lightbox options but I didn't want to have to modify the source.
As a change I moved the options out of the anonymous function scope to make them globally accessible. I can now override them in my app.
I also needed an autorotate feature.
I consolidated the next and prev logic into two new prototype functions, next() and prev() and replaced them in several places. I also add a prototypal autoSlide function that operates on a timer, and then cancels itself on any input from the user (i.e. click, keypress).
Let me know what you think. Thanks for the awesome library!