Conversation
|
This works pretty well, except the play button (YouTube) isn't really clickable without some real precision. Example: https://www.screencast.com/t/B2Ha5SHj |
|
Thanks @miyagisan85, I really appreciate Your comment! Actually my latest commit (02f0d6e) is about fixing the border (box-sizing) and in Please find my gif in which I highlight the nav areas and the YouTube play button. |
|
Ahh - it appears I downloaded the wrong version. I must have had a moment and thought the latest commit was at the top. Good show @peppertom, it appears to be working perfectly now. Hopefully this is merged in with the main project soon. |
|
thanks @miyagisan85 |
|
Hi @lokesh, any plans for merging this? Video support would be a great addition to the library. |
|
No plans to merge this in to Lightbox v2 as the project is in maintenance mode and I'm not making significant changes besides fixing bugs. I do appreciate the PRs and hopefully people can pick through the code they need in their personal fork. I am considering video support for the next major release but that is still in brainstorming mode and without a timeline. |
|
thankyou verry much for adding this feature.. |
|
Can someone help me? I tried lightbox code but it does not pop up the youtube video. Instead it opens the youtube website.
|
|
@Catarina6 Please check out the example: https://github.com/peppertom/lightbox2/blob/master/examples/video.html |
|
Hello @peppertom |
No description provided.