Add the Lokum AI banner and footer to the README - #16
Merged
Merged
Conversation
Two 4:1 images from the team, placed where they read as framing rather than decoration: the Iznik tile mural directly under the heading, the bazaar photograph as the last thing on the page. Both were 4128 px wide as generated, and GitHub renders a README at roughly 900. Resized to 2000 px, which is still double the display width so they stay sharp on a retina screen, and the pair went from 5.62 MB to 516 KB. The banner's own lettering is the thing that would have shown a bad resize first, and it is unchanged at render size. Alt text describes each picture rather than naming the file, because GitHub prints it when an image fails to load and a screen reader reads it aloud. The root README is outside the content pipeline: CONTENT_ROOT is mini-courses/, so the app reads only the category READMEs. Nothing here reaches the build, the link gate or the corpus tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two 4:1 images from the team, placed as framing rather than decoration:
Resized before committing
Both were 4128 px wide as generated, and GitHub renders a README at roughly 900 px, so the originals were serving about 4.5x more pixels than anyone sees on the first thing a visitor loads.
banner-tiles.jpegfooter-lokum.jpeg2000 px is still double the display width, so they stay sharp on a retina screen. The banner carries its own lettering, which is what a bad resize damages first, and it is unchanged at render size.
Two details
Alt text describes each picture rather than naming the file: GitHub prints it when an image fails to load, and a screen reader reads it aloud.
No em dashes. The README had none before, and
mini-courses/CLAUDE.mdbans them.Scope
The root
README.mdis outside the content pipeline.CONTENT_ROOTismini-courses/, so the app reads only the category READMEs; nothing here reaches the build, the link gate or the corpus tests.npm teststays at 2053 passing.Independent of #15, which touches only corpus files and
tests/. Either can merge first.