story: Fix tree story in web gallery - #2363
Merged
Merged
Conversation
Member
|
Thanks |
AzureZee
pushed a commit
to AzureZee/gpui-component
that referenced
this pull request
May 16, 2026
Closes longbridge#2139 ## Description Fixes the Tree story in the web gallery by avoiding filesystem reads in the WASM target. The native story still builds the tree from the local working directory, while the web gallery now uses static example tree data. This keeps the desktop behavior unchanged and makes the Tree example render correctly in the browser, where local filesystem access is unavailable. ## Screenshot | Before | After | | ------ | ----- | | <img width="3840" height="2080" alt="Before" src="https://github.com/user-attachments/assets/5e4c2861-469d-4a2e-a8b6-07fa9db7f116" /> | <img width="3840" height="2080" alt="After" src="https://github.com/user-attachments/assets/d5340448-e3b2-45ce-a0ee-132102c7ca9b" /> | ## How to Test ```bash cargo check -p gpui-component-story cargo clippy -p gpui-component-story -- -D warnings RUSTUP_TOOLCHAIN=nightly cargo check -p gpui-component-story-web --target wasm32-unknown-unknown cargo test -p gpui-component-story cargo test -p gpui-component tree::tests ``` Manual web verification: ```bash cd crates/story-web RUSTUP_TOOLCHAIN=nightly make dev ``` Open the local gallery URL, search for `tree`, and verify the Tree story displays a file tree and supports selection/expand behavior. ## Checklist - [x] I have read the [CONTRIBUTING](../CONTRIBUTING.md) document and followed the guidelines. - [x] Reviewed the changes in this PR and confirmed AI generated code (If any) is accurate. - [x] Passed `cargo run` for story tests related to the changes. - [ ] Tested macOS, Windows and Linux platforms performance (if the change is platform-specific)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2139
Description
Fixes the Tree story in the web gallery by avoiding filesystem reads in the WASM target.
The native story still builds the tree from the local working directory, while the web gallery now uses static example tree data. This keeps the desktop behavior unchanged and makes the Tree example render correctly in the browser, where local filesystem access is unavailable.
Screenshot
How to Test
Manual web verification:
cd crates/story-web RUSTUP_TOOLCHAIN=nightly make devOpen the local gallery URL, search for
tree, and verify the Tree story displays a file tree and supports selection/expand behavior.Checklist
cargo runfor story tests related to the changes.