Skip to content

feat(lvol): add APIs for delta snapshot rebuilding#210

Merged
derekbit merged 1 commit into
longhorn:mainfrom
DamiaSan:delta_snapshot_checksum
May 13, 2025
Merged

feat(lvol): add APIs for delta snapshot rebuilding#210
derekbit merged 1 commit into
longhorn:mainfrom
DamiaSan:delta_snapshot_checksum

Conversation

@DamiaSan
Copy link
Copy Markdown

Which issue(s) this PR fixes:

Issue longhorn/longhorn#10037

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 188 lines in your changes missing coverage. Please review.

Project coverage is 19.83%. Comparing base (ed9e6ca) to head (2bc7fa5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/cmd/basic/bdev_lvol.go 0.00% 140 Missing ⚠️
pkg/spdk/client/basic.go 0.00% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   20.50%   19.83%   -0.68%     
==========================================
  Files          37       37              
  Lines        5534     5722     +188     
==========================================
  Hits         1135     1135              
- Misses       4216     4404     +188     
  Partials      183      183              
Flag Coverage Δ
unittests 19.83% <0.00%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shuo-wu
shuo-wu previously approved these changes May 1, 2025
Copy link
Copy Markdown
Contributor

@shuo-wu shuo-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the spdk PR merge first.

@DamiaSan DamiaSan force-pushed the delta_snapshot_checksum branch from d662ca5 to 248b8bd Compare May 7, 2025 06:41
@DamiaSan DamiaSan requested a review from shuo-wu May 7, 2025 06:41
@DamiaSan DamiaSan force-pushed the delta_snapshot_checksum branch from 248b8bd to 8d7973e Compare May 8, 2025 11:09
Longhorn 10037

Signed-off-by: Damiano Cipriani <damiano.cipriani@suse.com>
@DamiaSan DamiaSan force-pushed the delta_snapshot_checksum branch from 8d7973e to 2bc7fa5 Compare May 12, 2025 04:21
@derekbit derekbit merged commit f55efae into longhorn:main May 13, 2025
5 of 8 checks passed
@derekbit
Copy link
Copy Markdown
Member

@DamiaSan Please submit a PR to update https://github.com/longhorn/dep-versions/blob/master/versions.json#L20-L25. Thanks. Also need to update go.mod in longhorn-spdk-engine and longhorn-instance-manager.

@DamiaSan
Copy link
Copy Markdown
Author

@DamiaSan Please submit a PR to update https://github.com/longhorn/dep-versions/blob/master/versions.json#L20-L25. Thanks. Also need to update go.mod in longhorn-spdk-engine and longhorn-instance-manager.

All done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants