feat: add SpdkKillInstance method and command and Increase BdevAioCreate timeout#232
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 37 38 +1
Lines 5842 5877 +35
=====================================
- Misses 5842 5877 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
derekbit
force-pushed
the
stop
branch
2 times, most recently
from
151f754 to
de16ea6
Compare
derekbit
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new SpdkKillInstance method and CLI command to send signals to SPDK applications, and increases the timeout for BdevAioCreate operations to handle longer-running operations.
- Introduces SpdkKillInstance functionality for sending signals to SPDK instances
- Updates BdevAioCreate to use a longer timeout for better reliability
- Adds enhanced error logging with method and parameter details
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/spdk/types/bdev.go | Adds SpdkKillInstanceRequest struct for signal name parameter |
| pkg/spdk/client/basic.go | Implements SpdkKillInstance method and updates BdevAioCreate timeout |
| pkg/jsonrpc/client.go | Enhances error logging with method and parameter information |
| main.go | Registers the new SpdkKillInstance CLI command |
| app/cmd/basic/instance.go | Implements CLI command for killing SPDK instances |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Longhorn 11760 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 11760 Signed-off-by: Derek Su <derek.su@suse.com>
disk bdev attachment might need much time if blobstore recover is required. Blobstore recover is called after a non-graceful shutdown of spdk_tgt. Longhorn 11760 Signed-off-by: Derek Su <derek.su@suse.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#11760
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context